PTEUDO-1422: Publish status events for state changes in database

[bfabricio]

Summary of changes

1. Expand the DatabaseClaimStatus condition list by adding more conditions.
2. Refactor the claim status logic and implement corresponding unit tests.
3. Create unit tests for the mode selector.

Demo

DB claim

---
apiVersion: persistance.atlas.infoblox.com/v1
kind: DatabaseClaim
metadata:
  name: fbottega-sample-database
  namespace: fbottega
spec:
  class: fbottega
  appId: some-app 
  secretName: sample-secret-name
  type: postgres
  userName: sample-user
  databaseName:  sample-db
  dsnName: dsn.txt
  dbVersion: "15.3"
  minStorageGB: 20 

$ make build-images push-images deploy
...

$ k get databaseclaim fbottega-sample-database -o yaml
...
  conditions:
  - lastTransitionTime: "2024-12-16T11:05:07Z"
    message: Database is provisioned.
    observedGeneration: 3
    reason: Available
    status: "True"
    type: Synced
  - lastTransitionTime: "2024-12-16T10:43:59Z"
    message: Database successfully synchronized and ready for use.
    observedGeneration: 3
    reason: Available
    status: "True"
    type: Ready
...

[leandrorichardtoledo]

You can change the method name to SetError since the struct already has the Status (StatusManager).

[drewwells]

At some point, this could be promoted to a panic. So we can identify and fix the duplidate error calls happening

[drewwells]

Shouldn't you check for deleted state before updating the status?

[drewwells]

I think you could move claimstatus out of the pkg/databaseclaim package.

[drewwells]

I would collapse these to something similiar to Crossplane ConditionReady, ConditionSync. All of these other condition states could be part of those 2.
ConditionSync would indicate if db-controller is performing any operation provisioning, deleting, migrating. It is True when all state is synced to Crossplane/AWS (requires checking Crossplane CR status). I would also consider that implicit versioning errors in the sync field as NeedsMigrate. That may require a separate ticket and be out of scope for this one.

Ready indicates the database is not just synced but available for user. User credentials are created and within rotation period. If credentials are expired, then ready should be false.

Status	ConditionReady	ConditionSync
Ready	True	True
Provisioning	True	False
Deleting	True	False
Migrating	True	False
ConnectionIssue	False	True

[leandrorichardtoledo]

The LastTransitionTime is set already when you create the condition:

db-controller/api/v1/condition.go

Lines 42 to 51 in 76cf740

	func CreateCondition(condType ConditionType, status metav1.ConditionStatus, reason, message string) metav1.Condition {
	now := metav1.NewTime(time.Now())
	return metav1.Condition{
	Type: string(condType),
	Status: status,
	Reason: reason,
	Message: message,
	LastTransitionTime: now,
	}
	}

.

[bfabricio]

Removed from the create condition as it makes more sense to keep it here, closer to the update operation.