(Preliminary) Solaris/SunOS support #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamcha
changed the title
| @@ -172,7 +172,7 @@ int ol_unjar_ds(ol_database *db, const char *key, size_t klen, unsigned char **d | |||
| * xXx *value=The value to insert. xXx | |||
| * xXx vsize=The size of the value in bytes. xXx | |||
| */ | |||
| int ol_jar(ol_database *db, const char *key, size_t klen, unsigned char *value, size_t vsize); | |||
| int ol_jar(ol_database *db, const char *key, size_t klen, unsigned char* value, size_t vsize); | |||
There was a problem hiding this comment.
MOVING MY ASTERISKS AROUND BRO?
There was a problem hiding this comment.
Didn't notice that, woah.
qpfiffer
added a commit
that referenced
this pull request
Jul 16, 2014
(Preliminary) Solaris/SunOS support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiles on SmartOS (SunOS / illumos) using GCC 4.7.
Clang complains about "madvise" not being "posix.madvise" but I don't have any "elegant" solution to fix that for now (and it fails linking afterwards because of conflicts anyway.. I think clang on SunOS is just broken).
Tests fail but it's intended apparently.
The frontend works fine.
As we discussed on IRC, we should evaluate doing a
sun.mkoverride makefile, but we can do that later.Part of #112