Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elias's favorite number #86

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Add Elias's favorite number #86

merged 2 commits into from
Mar 23, 2024

Conversation

eliasow
Copy link
Contributor

@eliasow eliasow commented Mar 22, 2024

Added my favorite number to numbers.csv

@eliasow eliasow requested a review from sfelshin March 22, 2024 19:58
@sfelshin
Copy link
Contributor

@eliasow, I see you have added me as a reviewer, but you haven't assigned the PR to me. Hm, perhaps you mean that the PR isn't ready for review yet? More likely you forgot to assign me... I'll wait to be assigned before reviewing.

A PR should always be assigned to whoever is currently responsible for taking action (develop, review, test, whatever). The only time a PR should be unassigned is if the responsible party has departed and abandoned the PR, and there is no one else to assign it to.

Copy link
Contributor

@sfelshin sfelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub indicates that the file doesn't end in a newline:
image
Modern unix programs are often smart about it, but old-fashioned programs still read input line by line and detect each line by virtue of it ending in a newline* such that if the last line of the file doesn't end in a newline, it is ignored. For safety's sake, make sure the file ends in a newline. The Infolab has set up Emacs to add a final newline when saving a file, if there isn't one already. Perhaps your editing environment has a similar option.

* where "newline" means the appropriate CRLF character(s) for the operating system

@sfelshin sfelshin assigned eliasow and unassigned sfelshin Mar 22, 2024
@eliasow eliasow assigned sfelshin and unassigned eliasow Mar 22, 2024
Copy link
Contributor

@sfelshin sfelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but for future reference, a better commit message would have been "Add newline at end of file".

@sfelshin sfelshin assigned eliasow and unassigned sfelshin Mar 23, 2024
@eliasow eliasow merged commit 4cb93e2 into master Mar 23, 2024
1 check passed
@eliasow eliasow deleted the add-Elias-fav-num branch March 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants