Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for ICS20 v2 #4008

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8c179d3
Use patched ibc-proto-rs for ICS20 v2 protos
ljoss17 May 30, 2024
15b75ed
Update channel version handling and add ICS20 v2 compatibility
ljoss17 May 30, 2024
f233ec0
Update tests with new channel version handling and add ICS20 v2 test
ljoss17 May 30, 2024
d05bc5a
Codespell fix
ljoss17 May 30, 2024
fc41cdc
Apply github suggestions
ljoss17 May 30, 2024
b465f9f
Use UID and GID 2000 when creating Docker image
ljoss17 Jun 6, 2024
f330d11
Merge branch 'master' into luca_joss/add-compatibility-to-ics20-v2
ljoss17 Jul 23, 2024
3623930
Merge branch 'master' into luca_joss/add-compatibility-to-ics20-v2
ljoss17 Aug 21, 2024
0a90e5d
Add ICS20 v2 feature to ibc-go v9 tests
ljoss17 Aug 21, 2024
f68c5e8
Improve method 'is_ics20_v2'
ljoss17 Aug 21, 2024
8ac128e
Set MsgTransfer as an enum for ICS20 v1 and v2
ljoss17 Aug 22, 2024
0e8832d
Update ibc_transfer_token to work with ICS20 v1 and v2 depending on c…
ljoss17 Aug 22, 2024
b819034
Clean ibc transfers in tests
ljoss17 Aug 22, 2024
9475ced
Fix clippy error
ljoss17 Aug 22, 2024
661c3f4
Fix denom trace query
ljoss17 Aug 23, 2024
01fcc79
Fix sequential filter tests
ljoss17 Aug 23, 2024
5fad8a7
Update guide template
ljoss17 Aug 23, 2024
4ab202e
Patch ibc-proto-rs in check-guide
ljoss17 Aug 23, 2024
788b70d
Revert change required with patched ibc-proto-rs
ljoss17 Aug 23, 2024
91f9306
Remove unnecessary channel/ics20 version field in options and flags f…
ljoss17 Aug 26, 2024
af93eb6
Update template
ljoss17 Aug 26, 2024
fcf2b23
Cleanup code
ljoss17 Aug 26, 2024
d4816ff
Deserialize ics20 v2 packet data with Protobuf (#4165)
ljoss17 Aug 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Deserialize ICS20 v2 packet data using Protobuf instead of JSON
([\#4098](https://github.com/informalsystems/hermes/issues/4098))
2 changes: 1 addition & 1 deletion .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
command: simd
account_prefix: cosmos
native_token: stake
features: ica,ics29-fee,new-register-interchain-account,channel-upgrade,authz,no-denom-trace
features: ica,ics29-fee,new-register-interchain-account,channel-upgrade,authz,no-denom-trace,ics20-v2
- package: wasmd
command: wasmd
account_prefix: wasm
Expand Down
105 changes: 52 additions & 53 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ uuid = "1.10.0"
overflow-checks = true

[patch.crates-io]
ibc-proto = { git = "https://github.com/cosmos/ibc-proto-rs.git", branch = "luca_joss/update-ibc-go-commit" }
# tendermint = { git = "https://github.com/informalsystems/tendermint-rs.git", branch = "main" }
# tendermint-rpc = { git = "https://github.com/informalsystems/tendermint-rs.git", branch = "main" }
# tendermint-proto = { git = "https://github.com/informalsystems/tendermint-rs.git", branch = "main" }
Expand Down
Loading