Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-1130 improve JPA methods - admtype package #339

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

dbmalkovsky
Copy link
Collaborator

@dbmalkovsky dbmalkovsky commented Sep 29, 2023

See OP-1130

Changes for the admtype package.

Matching changes for CORE PR: informatici/openhospital-core#1105

@dbmalkovsky dbmalkovsky requested a review from mwithi September 29, 2023 12:32
@mwithi mwithi changed the title OP-1130 improve JPA methods OP-1130 improve JPA methods - admtype package Sep 30, 2023
@dbmalkovsky
Copy link
Collaborator Author

Closing this PR to try a different approach.

@dbmalkovsky dbmalkovsky closed this Oct 3, 2023
@dbmalkovsky
Copy link
Collaborator Author

This method is the one of choice; reopening.

@dbmalkovsky dbmalkovsky reopened this Oct 4, 2023
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit f3ac3a1 into informatici:develop Oct 5, 2023
1 check failed
@dbmalkovsky dbmalkovsky deleted the OP-1130-admtype branch October 6, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants