OP-1373 remove warns at api startup #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need at the moment to define an authenticationProvider because we have only one UserDetailsService implementation (org.isf.security.UserDetailsServiceImpl) and only one PasswordEncoder bean (BCryptPasswordEncoder), so Spring Security uses the default DaoAuthenticationProvider In the future, if we add more UserDetailsService implementations for multiple authentication data sources (e.g. Database, LDAP, Third-Party) we must define each provider and instruct the AuthenticationManager in which one to use for each case.
because it is needed to start the application even without DB connection for the openapi workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OP-1373.
Notes:
spring.jpa.open-in-viewis generally recommended for REST APIs to prevent performance issues and ensure explicit data fetchingorg.isf.security.UserDetailsServiceImpl) and only one PasswordEncoder bean (BCryptPasswordEncoder), so Spring Security uses the default DaoAuthenticationProvider. In the future, if we add more UserDetailsService implementations for multiple authentication data sources (e.g. Database, LDAP, Third-Party) we must define each provider and instruct the AuthenticationManager in which one to use for each case.NOTE:
WARN - HHH90000025: MariaDBDialect ...not eliminable because it is needed to start the application even without DB connection for the openapi workflow and in general