Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split adress iput field #277

Merged
merged 2 commits into from
Nov 16, 2021
Merged

split adress iput field #277

merged 2 commits into from
Nov 16, 2021

Conversation

emely3h
Copy link
Collaborator

@emely3h emely3h commented Oct 13, 2021

Related Issue

  • So far there was no unified format for the address input field
  • So far there were no specific error messages for guests if input fields were empty and they tried to check in

Proposed Changes

  • I split the address and name field in multiple fields so that the data send to the database has a unified format
  • Before sending the form I checked if any fields are still empty and if so specific error messages were displayed
  • I made the input fields responsive so that they are not cut of on smartphones

Additional Info

  • pleas test the frontend as I am not sure if I did everything correct when solving merge conflicts

Checklist

  • Is the code formatted correctly?
  • Unnecessary comments removed?
  • Printout statements removed?
  • If you made backend changes: Did all tests pass? Do you need to adjust some tests or write new ones?
  • If you made frontend changes: Did you test the UI on different devices/ browsers (Firefox, Chrome, Safari, different smartphone sizes)
  • Is your code easy to understand or do you need to insert some comments?
  • Explain the issue for the reviewer and your steps to solve the issue => makes it a lot more easy for the reviewer
  • Label your pull request (frontend/ backend/ testing/ styling/ sql/...)
  • Is the open source message included at the very beginning of every source code file?
  • Are all imports organized, i.e. are the imports up to date and have all package imports been removed?

@emely3h emely3h changed the title split fields + responsive + check for empty fields split adress iput field Oct 13, 2021
@Gabril-E Gabril-E self-assigned this Oct 21, 2021
changed Placeholder
@Gabril-E
Copy link
Collaborator

Moved bug to new Issue #284 to merge this request

@Gabril-E Gabril-E merged commit 6875ed7 into dev Nov 16, 2021
@oliverhummel oliverhummel deleted the feature/guestAdressInput branch December 2, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants