Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcluster delete --ignore-not-found #12

Open
wants to merge 1 commit into
base: develop_bkp
Choose a base branch
from

Conversation

Kartik-Garg
Copy link
Collaborator

Added a new flag --ignore-not-found, which ignores the resource if the flag is mentioned instead of throwing and error and exiting

What issue type does this pull request address? (keep at least one, remove the others)
/kind feature

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves 771

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
Added a new flag --ignore-not-found that will not exit with an error code, in case if the vlcuster to be deleted does not exist

What else do we need to know?

@Kartik-Garg Kartik-Garg force-pushed the ignore-not-found-flag branch 2 times, most recently from 763922f to ff39a6e Compare April 3, 2023 17:59
Copy link

@sigmabaryon sigmabaryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/vclusterctl/cmd/delete.go Outdated Show resolved Hide resolved
cmd/vclusterctl/cmd/delete.go Outdated Show resolved Hide resolved
@Kartik-Garg Kartik-Garg force-pushed the ignore-not-found-flag branch from ff39a6e to 60c77e2 Compare April 4, 2023 07:34
@samkulkarni20 samkulkarni20 requested a review from neogopher April 4, 2023 12:28
@Kartik-Garg Kartik-Garg force-pushed the ignore-not-found-flag branch 2 times, most recently from 1dbca4a to 2452565 Compare April 10, 2023 09:19
Copy link
Collaborator

@neogopher neogopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Added a new flag --ignore-not-found, which ignores the resource if the flag is mentioned instead of throwing and error and exiting

Signed-off-by: Kartik-Garg <[email protected]>
@Kartik-Garg Kartik-Garg force-pushed the ignore-not-found-flag branch from 2452565 to 32eda4b Compare April 10, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants