Allow annotation of all objects created by the eks,8s and k0s charts #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kartik-Garg
force-pushed
the
annotations-global
branch
3 times, most recently
from
cc77892 to
3e08dc9
Compare
Kartik-Garg
requested review from
sigmabaryon,
samkulkarni20,
ApsTomar and
neogopher
Kartik-Garg
force-pushed
the
annotations-global
branch
2 times, most recently
from
98a3db2 to
ff3a74a
Compare
Kartik-Garg
force-pushed
the
annotations-global
branch
from
ff3a74a to
38bef52
Compare
…s charts Added annotation of all objects created by the eks,8s and k0s charts. Signed-off-by: Kartik-Garg <[email protected]>
Kartik-Garg
force-pushed
the
annotations-global
branch
from
38bef52 to
50392ff
Compare
|
If the changes are similar for a lot of the objects for each chart, can we use |
@sigmabaryon Thanks for reviewing and for the suggestion, I had a look into it. But since the annotations are not same in all the files, for now I think it'd be better to approach it without using a template file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added annotation of all objects created by the eks,8s and k0s charts.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves 714
Please provide a short message that should be published in the vcluster release notes
Added helm value "global.annotations" to eke, k8s and k0s charts that will add its annotations to all objects created in the chart. Annotations for specific objects have precedence over global ones.
What else do we need to know?