Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baker as a Service #374

Merged
merged 91 commits into from
Dec 13, 2019
Merged

Baker as a Service #374

merged 91 commits into from
Dec 13, 2019

Conversation

VledicFranco
Copy link
Contributor

No description provided.

Tim-Linschoten and others added 30 commits November 26, 2019 13:32
@Tim-Linschoten @VledicFranco
Start on making the InteractionInstances be called via an Actor to al…
b0afeb6 
…low for remoting
@VledicFranco
Added the new InteractionManager protocol and a first implementation …
76ede3d 
…of the InteractionAgent
@VledicFranco
Algorithm work
0a53529
@VledicFranco
InteractionAgent concept finished
04c2cc8
@Tim-Linschoten @VledicFranco
Connected the new quest mechanism to Baker and allow for remote inter…
ccae2cd 
…actions.

Now has a very very very very naive binding between Instance and descriptor of interactions.
@Tim-Linschoten @VledicFranco
Fixed unit test by changing node.
df2c658
@Tim-Linschoten @VledicFranco
Added basic logging for the new components
add2004
@Tim-Linschoten @VledicFranco
Added some trace UUID information to the logs.
3c3c6f9
@VledicFranco
Tests updated
99c382a
@Tim-Linschoten @VledicFranco
Added timeout for how long a agent can be considering.
8c1faab 
Removed the committed state and go into receive state directly.
@VledicFranco
Added proto serialization to scheduling messages
27a75ba
@VledicFranco
Implemented client and server for BaaS (only 1 method)
4c93387
@VledicFranco
Continued work on the server/client for baas
63abc8f
@VledicFranco
Finished the proto mappings and as well the server and client
5451cd0
@VledicFranco
Continued work on the testing of the BaaS client-server communication
41ed5e0
@VledicFranco
Finished testing the client server interactions
adfd2ad
@VledicFranco
minor
49bac79
@VledicFranco
finished the serialization of BakerExceptions
e81c5cd
@VledicFranco
Created Java API for the remote baker
0df4849
@Tim-Linschoten @VledicFranco
Removed println in test.
8ffa25d
@VledicFranco
typos and minor fixes
8353dcf
@VledicFranco
minor
be0f153
@VledicFranco
WIP separation of the interface
04ea311
@VledicFranco
Finished moving the interface into its own project
ec39395
@VledicFranco
Fixes typos created by Intellij refactoring tool D:
2157818
@VledicFranco
Fixes typos created by Intellij refactoring tool D:
2d6498c
@VledicFranco
Fixes typos created by Intellij refactoring tool D:
bdf4eb6
@VledicFranco
Fixes typos created by Intellij refactoring tool D:
fdbf23d
@VledicFranco
WIP baas project separation
7b04648
@VledicFranco
WIP baas project separation
e26bab2
@codecov-io
Copy link

codecov-io commented Dec 10, 2019 •
edited
Loading

Codecov Report

Merging #374 into master will increase coverage by 2.28%.
The diff coverage is 72.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   81.18%   83.47%   +2.28%     
==========================================
  Files         128       77      -51     
  Lines        3317     2632     -685     
  Branches       84       68      -16     
==========================================
- Hits         2693     2197     -496     
+ Misses        624      435     -189
Impacted Files Coverage Δ
...e/akka/actor/process_index/ProcessIndexProto.scala 99.48% <ø> (ø) ⬆️
...tor/process_instance/ProcessInstanceProtocol.scala 27.77% <ø> (ø) ⬆️
...time/akka/actor/recipe_manager/RecipeManager.scala 100% <ø> (+4.34%) ⬆️
...untime/akka/actor/process_index/ProcessIndex.scala 84.83% <ø> (+2.8%) ⬆️
...akka/actor/recipe_manager/RecipeManagerProto.scala 100% <ø> (ø) ⬆️
...r/runtime/akka/actor/LocalBakerActorProvider.scala 100% <ø> (ø) ⬆️
...ain/scala/com/ing/baker/runtime/akka/package.scala 57.14% <ø> (-6.86%) ⬇️
...a/com/ing/baker/runtime/akka/AkkaBakerConfig.scala 10.52% <ø> (ø) ⬆️
...kka/actor/process_index/ProcessIndexProtocol.scala 100% <ø> (ø) ⬆️
.../actor/process_instance/ProcessInstanceProto.scala 97.81% <ø> (ø) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6693a...e086eca. Read the comment docs.

@VledicFranco VledicFranco changed the title Baker as a Service [WIP] Baker as a Service Dec 10, 2019
stasimus
stasimus suggested changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@stasimus stasimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address TODO

baas-node-event-listener/src/main/scala/com/ing/baker/baas/scaladsl/BaaSEventListener.scala Show resolved Hide resolved
baas-tests/src/test/scala/com/ing/baker/baas/recipe/ReserveItemsInstance.scala Show resolved Hide resolved
baas-tests/src/test/scala/com/ing/baker/baas/recipe/ShipItemsInstance.scala Show resolved Hide resolved
baker-interface/src/main/scala/com/ing/baker/runtime/serialization/TokenIdentifier.scala Show resolved Hide resolved
runtime/src/main/scala/com/ing/baker/runtime/akka/AkkaBakerConfig.scala Outdated Show resolved Hide resolved
@VledicFranco VledicFranco merged commit 3cf7c09 into master Dec 13, 2019
@jacum jacum deleted the DEV-BaaS branch March 27, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stasimus stasimus stasimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VledicFranco @codecov-io @stasimus @Tim-Linschoten