Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs and workflow #3

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
name: ":bug: Bug Report"
about: Create a bug report to help us improve the repo
title: "[BUG]: "
labels: bug
---

## Description

Please provide a clear and concise description of the bug.

### Reproduce

Please list the steps to reproduce the issue.

## Expected Behavior

Please provide a clear and concise description of what you expected to happen.

## Environment

Please complete the following information:

OS + Version:

Cargo Version:

GPU type:

## Additional context

Please provide any additional context that may be helpful in confirming and resolving this issue.
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: ":sparkles: Feature Request"
about: Request the inclusion of a new feature or functionality
title: "[FEAT]: "
labels: enhancement
---

## Description

Please provide a clear and concise description of the feature you would like included.

## Motivation

Please provide a clear and concise description of the motivation for adding this feature.
7 changes: 7 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## Describe the changes

This PR...

## Linked Issues

Resolves #
16 changes: 16 additions & 0 deletions .github/workflows/main-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Lint

on:
pull_request:
branches:
- main

jobs:
formatting-golang:
name: Check Golang Code Formatting
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Check gofmt
run: if [[ $(go list ./... | xargs go fmt) ]]; then echo "Please run go fmt"; exit 1; fi
32 changes: 32 additions & 0 deletions .github/workflows/main-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Test

on:
pull_request:
branches:
- main

env:
CARGO_TERM_COLOR: always
ARCH_TYPE: sm_70

jobs:
test-golang-linux:
name: Test Golang on Linux
runs-on: [self-hosted, Linux, X64, icicle]
steps:
- name: Checkout Repo
uses: actions/checkout@v3
- name: Build CUDA libs
run: |
git clone https://github.com/username/another-repo.git
cd another-repo/goicicle
ImmanuelSegol marked this conversation as resolved.
Show resolved Hide resolved
Comment on lines +21 to +22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure what the purpose of this clone here is. It seems like we are trying to clone another repo, though it is a fake/non-existent repo?

make all
cd ~/go/pkg/mod/github.com/ingonyama-zk/[email protected]/goicicle
chmod +x setup.sh

echo "Compiling all ICICLE curves..."
make all
echo "LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(pwd)/goicicle" >> $GITHUB_ENV
- name: Run Golang Tests
run: |
go test ./bn254 ./bls12377 -count=1
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## ICICLE-GNARK WRAPPER

This repo contains wrappers for common ICICLE methods used within the ICICLE <> Gnark integration.
16 changes: 8 additions & 8 deletions curves/bn254/g1_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 16 additions & 17 deletions curves/bn254/msm_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions curves/bn254/ntt_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading