Skip to content

Commit

Permalink
feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@Vritra4
Vritra4 committed Nov 14, 2024
1 parent 8a81401 commit dedb34e
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 29 deletions.
4 changes: 4 additions & 0 deletions .github/config/.codespellignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ EyT
upTo
initia
minitia
expRes
metadataA
totalIn
totalOut
36 changes: 18 additions & 18 deletions client/docs/swagger-ui/swagger.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12102,7 +12102,7 @@ paths:
vetoed. Default value: 1/3.
params:
description: |-
params defines all the paramaters of x/gov module.
params defines all the parameters of x/gov module.

Since: cosmos-sdk 0.47
type: object
Expand Down Expand Up @@ -20343,7 +20343,7 @@ paths:
- Query
/cosmos/feegrant/v1beta1/allowance/{granter}/{grantee}:
get:
summary: Allowance returns granted allwance to the grantee by the granter.
summary: Allowance returns granted allowance to the grantee by the granter.
operationId: Allowance
responses:
'200':
Expand Down Expand Up @@ -34969,7 +34969,7 @@ paths:
format: uint64
- name: latest_height
description: >-
latest_height overrrides the height field and queries the latest
latest_height overrides the height field and queries the latest
stored

ConsensusState.
Expand Down Expand Up @@ -36564,7 +36564,7 @@ paths:
identifier
description: >-
Version defines the versioning scheme used to
negotiate the IBC verison in
negotiate the IBC version in

the connection handshake.
title: >-
Expand Down Expand Up @@ -36973,7 +36973,7 @@ paths:
identifier
description: >-
Version defines the versioning scheme used to negotiate
the IBC verison in
the IBC version in

the connection handshake.
description: >-
Expand Down Expand Up @@ -52943,7 +52943,7 @@ paths:
finalization_period:
type: string
description: >-
The minium time duration that must elapse before a
The minimum time duration that must elapse before a
withdrawal can be finalized.
submission_start_height:
type: string
Expand Down Expand Up @@ -53114,7 +53114,7 @@ paths:
finalization_period:
type: string
description: >-
The minium time duration that must elapse before a
The minimum time duration that must elapse before a
withdrawal can be finalized.
submission_start_height:
type: string
Expand Down Expand Up @@ -65859,7 +65859,7 @@ definitions:
vetoed. Default value: 1/3.
params:
description: |-
params defines all the paramaters of x/gov module.
params defines all the parameters of x/gov module.

Since: cosmos-sdk 0.47
type: object
Expand Down Expand Up @@ -68743,7 +68743,7 @@ definitions:
gas to be used by the transaction. The ratio yields an effective
"gasprice",

which must be above some miminum to be accepted into the mempool.
which must be above some minimum to be accepted into the mempool.
cosmos.tx.v1beta1.GetBlockWithTxsResponse:
type: object
properties:
Expand Down Expand Up @@ -79635,7 +79635,7 @@ definitions:
title: list of features compatible with the specified identifier
description: >-
Version defines the versioning scheme used to negotiate the IBC
verison in
version in

the connection handshake.
description: >-
Expand Down Expand Up @@ -79757,7 +79757,7 @@ definitions:
title: list of features compatible with the specified identifier
description: >-
Version defines the versioning scheme used to negotiate the IBC
verison in
version in

the connection handshake.
title: >-
Expand Down Expand Up @@ -80342,7 +80342,7 @@ definitions:
title: list of features compatible with the specified identifier
description: >-
Version defines the versioning scheme used to negotiate the IBC
verison in
version in

the connection handshake.
description: >-
Expand Down Expand Up @@ -80479,7 +80479,7 @@ definitions:
title: list of features compatible with the specified identifier
description: >-
Version defines the versioning scheme used to negotiate the
IBC verison in
IBC version in

the connection handshake.
title: >-
Expand Down Expand Up @@ -80625,7 +80625,7 @@ definitions:
type: string
title: list of features compatible with the specified identifier
description: |-
Version defines the versioning scheme used to negotiate the IBC verison in
Version defines the versioning scheme used to negotiate the IBC version in
the connection handshake.
ibc.applications.transfer.v1.DenomTrace:
type: object
Expand Down Expand Up @@ -81747,7 +81747,7 @@ definitions:
format: uint64
title: packet sequence
title: |-
PacketId is an identifer for a unique Packet
PacketId is an identifier for a unique Packet
Source chains refer to packets by source port/channel
Destination chains refer to packets by destination port/channel
ibc.applications.perm.v1.ChannelState:
Expand Down Expand Up @@ -88440,7 +88440,7 @@ definitions:
finalization_period:
type: string
description: >-
The minium time duration that must elapse before a withdrawal can be
The minimum time duration that must elapse before a withdrawal can be
finalized.
submission_start_height:
type: string
Expand Down Expand Up @@ -88601,7 +88601,7 @@ definitions:
finalization_period:
type: string
description: >-
The minium time duration that must elapse before a withdrawal can
The minimum time duration that must elapse before a withdrawal can
be finalized.
submission_start_height:
type: string
Expand Down Expand Up @@ -88663,7 +88663,7 @@ definitions:
finalization_period:
type: string
description: >-
The minium time duration that must elapse before a
The minimum time duration that must elapse before a
withdrawal can be finalized.
submission_start_height:
type: string
Expand Down
2 changes: 1 addition & 1 deletion x/bank/keeper/msg_server.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (k msgServer) MultiSend(goCtx context.Context, msg *types.MsgMultiSend) (*t

ctx := sdk.UnwrapSDKContext(goCtx)

// NOTE: total In == total Out should already have been checked
// NOTE: totalIn == totalOut should already have been checked
if err := k.IsSendEnabledCoins(ctx, in.Coins...); err != nil {
return nil, err
}
Expand Down
16 changes: 8 additions & 8 deletions x/move/client/cli/utils_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ func Test_readJSONStringArray(t *testing.T) {
testCases := []struct {
name string
s string
express []string
expRes []string
expErr bool
}{
{"empty", "", []string{}, false},
Expand All @@ -30,17 +30,17 @@ func Test_readJSONStringArray(t *testing.T) {
require.Error(t, err, tc.name)
} else {
require.NoError(t, err, tc.name)
require.Equal(t, tc.express, res, tc.name)
require.Equal(t, tc.expRes, res, tc.name)
}
}
}

func Test_decodeJSONStringArray(t *testing.T) {
testCases := []struct {
name string
ss []string
name string
ss []string
express []string
expErr bool
expErr bool
}{
{"empty", []string{}, []string{}, false},
{"empty array", []string{}, []string{}, false},
Expand All @@ -62,10 +62,10 @@ func Test_decodeJSONStringArray(t *testing.T) {

func Test_BCSEncode(t *testing.T) {
testCases := []struct {
arg string
arg string
express []byte
expErr bool
name string
expErr bool
name string
}{
{"raw_hex:014c6f72656d00497073756d02", []byte{0x0d, 0x01, 0x4c, 0x6f, 0x72, 0x65, 0x6d, 0x00, 0x49, 0x70, 0x73, 0x75, 0x6d, 0x02}, false, "raw_hex \\x01Lorem\\x00Ipsum\\x02"},
{"raw_base64:AUxvcmVtAElwc3VtAg==", []byte{0x0d, 0x01, 0x4c, 0x6f, 0x72, 0x65, 0x6d, 0x00, 0x49, 0x70, 0x73, 0x75, 0x6d, 0x02}, false, "raw_base64 \\x01Lorem\\x00Ipsum\\x02"},
Expand Down
4 changes: 2 additions & 2 deletions x/move/keeper/balancer.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ func (k BalancerKeeper) poolMetadata(ctx context.Context, metadataLP vmtypes.Acc
return nil, err
}

metadata, _, err := k.Keeper.MoveBankKeeper().Balance(ctx, storeA)
metadataA, _, err := k.Keeper.MoveBankKeeper().Balance(ctx, storeA)
if err != nil {
return nil, err
}
Expand All @@ -216,7 +216,7 @@ func (k BalancerKeeper) poolMetadata(ctx context.Context, metadataLP vmtypes.Acc
return nil, err
}

return []vmtypes.AccountAddress{metadata, metadataB}, nil
return []vmtypes.AccountAddress{metadataA, metadataB}, nil
}

func (k BalancerKeeper) poolBalances(ctx context.Context, metadataLP vmtypes.AccountAddress) (balances []math.Int, err error) {
Expand Down

0 comments on commit dedb34e

Please sign in to comment.