-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing stargate query support #285
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request introduce new query routes to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/keepers/keepers.go (1)
642-653
: LGTM! Consider a minor improvement for consistency.The addition of new query routes for the oracle module in the
MoveKeeper
configuration looks good. These routes (GetAllCurrencyPairs, GetPrice, and GetPrices) expand the functionality available to the Move VM, allowing it to interact with oracle data.For improved consistency, consider grouping these new routes with other oracle-related configurations if they exist elsewhere in the file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 40.59% 40.61% +0.02%
==========================================
Files 267 267
Lines 25400 25412 +12
==========================================
+ Hits 10310 10322 +12
Misses 13503 13503
Partials 1587 1587
|
* support multisend * bump movevm to v0.5.1 * add missing stargate query support (#285) * fix nil memory access on authz (#281) * fix: allow to be failed with invalid message without error (#283) * allow to failed with invalid message * set reason * fix to consider movevm gas scale when we use infinity gas meter (#287) * fix to use cache context at ibc hook (#288) * feat: enable whitelist stableswap (#289) * enable whitelist stableswap * check division by zero and handle default values for balancer * remove unnecessary slices.Copy * ignore error * fix test * apply coderabbit comment * emit same events with cosmos-sdk interface * create account if not exists
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...