feat: introduce ibctesting feature #306
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Dockerfile to change the version of the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Dependency ReviewThe following issues were found:
License Issuesgo.mod
Denied Licenses: GPL-1.0-or-later, LGPL-2.0-or-later OpenSSF Scorecard
Scanned Files
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
Dockerfile (2)
Line range hint
24-26: Implement hash verification for downloaded librariesThe commented-out hash verification should be implemented to ensure the integrity of downloaded libraries.
Consider uncommenting and implementing the hash verification:
wget -O /lib/libmovevm_muslc.${ARCH}.a https://github.com/initia-labs/movevm/releases/download/${LIBMOVEVM_VERSION}/libmovevm_muslc.${ARCH}.a; \ wget -O /lib/libcompiler_muslc.${ARCH}.a https://github.com/initia-labs/movevm/releases/download/${LIBMOVEVM_VERSION}/libcompiler_muslc.${ARCH}.a; \ cp /lib/libmovevm_muslc.${ARCH}.a /lib/libmovevm_muslc.a; \ -cp /lib/libcompiler_muslc.${ARCH}.a /lib/libcompiler_muslc.a +cp /lib/libcompiler_muslc.${ARCH}.a /lib/libcompiler_muslc.a; \ +echo "${EXPECTED_MOVEVM_HASH} /lib/libmovevm_muslc.${ARCH}.a" | sha256sum -c; \ +echo "${EXPECTED_COMPILER_HASH} /lib/libcompiler_muslc.${ARCH}.a" | sha256sum -cYou'll need to add the hash variables at the top of the Dockerfile:
+ARG EXPECTED_MOVEVM_HASH="<hash-value-here>" +ARG EXPECTED_COMPILER_HASH="<hash-value-here>"
Line range hint
1-53: Consider using COPY --link for better build performanceWhile reviewing the multi-stage build setup, I noticed an opportunity for optimization.
Consider using
COPY --linkfor the final binary copy to improve build performance:-COPY --from=go-builder /code/build/initiad /usr/local/bin/initiad +COPY --link --from=go-builder /code/build/initiad /usr/local/bin/initiadThis optimization uses mount points instead of copying data during build time, resulting in faster builds and reduced disk usage.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sum
📒 Files selected for processing (1)
Dockerfile(1 hunks)
| @@ -6,7 +6,7 @@ ARG TARGETARCH | |||
| ARG GOARCH | |||
|
|
|||
| # See https://github.com/initia-labs/movevm/releases | |||
| ENV LIBMOVEVM_VERSION=v0.6.0 | |||
| ENV LIBMOVEVM_VERSION=v0.6.1 | |||
There was a problem hiding this comment.
💡 Codebase verification
Required library artifacts are missing for movevm v0.6.1
The version v0.6.1 was released on 2024-11-21, but the required library artifacts are not available in the release:
- ✗ libmovevm_muslc.x86_64.a not found
- ✗ libcompiler_muslc.x86_64.a not found
- ✗ libmovevm_muslc.aarch64.a not found
- ✗ libcompiler_muslc.aarch64.a not found
This will cause the Docker build to fail. Please ensure the required library artifacts are published to the release before updating the version.
🔗 Analysis chain
Verify movevm v0.6.1 release and its compatibility
The version update from v0.6.0 to v0.6.1 needs verification to ensure stability and compatibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the movevm v0.6.1 release and required artifacts
# Check if the release exists and get release info
echo "Checking release v0.6.1..."
gh api repos/initia-labs/movevm/releases/tags/v0.6.1 | jq -r '.name, .prerelease, .published_at'
# Verify the existence of required library artifacts for both architectures
echo -e "\nChecking required artifacts..."
for ARCH in "x86_64" "aarch64"; do
for LIB in "libmovevm_muslc" "libcompiler_muslc"; do
URL="https://github.com/initia-labs/movevm/releases/download/v0.6.1/${LIB}.${ARCH}.a"
if curl --output /dev/null --silent --head --fail "$URL"; then
echo "✓ ${LIB}.${ARCH}.a exists"
else
echo "✗ ${LIB}.${ARCH}.a not found"
fi
done
done
Length of output: 1822
Description
Bump movevm to v0.6.1 to introduce ibctesting feature.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...