Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary comma #4

Merged
merged 3 commits into from
Oct 31, 2023
Merged

remove unnecessary comma #4

merged 3 commits into from
Oct 31, 2023

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Oct 30, 2023

fmt.Sprintf(",%s", sdk.MsgTypeURL(msg)) always produces unncessary comma

@Vritra4 Vritra4 requested review from ALPAC-4, beer-1 and a team October 30, 2023 02:55
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #4 (a2f5022) into main (72af8a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   46.91%   46.91%           
=======================================
  Files         148      148           
  Lines       14512    14512           
=======================================
  Hits         6808     6808           
  Misses       6942     6942           
  Partials      762      762

@Vritra4
Copy link
Contributor Author

Vritra4 commented Oct 30, 2023 •
edited
Loading

i made an identical pr for cosmos-sdk: 18300

beer-1
beer-1 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit d027a7a into main Oct 31, 2023
7 checks passed
@beer-1 beer-1 deleted the fix-typo branch October 31, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beer-1 beer-1 beer-1 approved these changes

@ALPAC-4 ALPAC-4 Awaiting requested review from ALPAC-4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vritra4 @beer-1