Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/spellcheck #73

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Chore/spellcheck #73

merged 2 commits into from
Nov 15, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Nov 15, 2024

Description

similar with initia`s, add a workflow to check spell


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Introduced an automated spell-checking workflow for pull requests to identify and correct typographical errors.
  • Bug Fixes
    • Corrected typographical errors in comments across various files for clarity and accuracy.
  • Chores
    • Updated the .codespellignore file with new terms to avoid false positives during spell checks.
    • Streamlined installation commands in the Dockerfile for improved efficiency.

@Vritra4 Vritra4 requested a review from a team as a code owner November 15, 2024 03:24
Copy link

coderabbitai bot commented Nov 15, 2024

Walkthrough

This pull request introduces several changes aimed at improving spell checking and documentation clarity within the project. A new GitHub Actions workflow for automated spell checking is added, along with a list of terms to be ignored by the spell checker. Minor corrections in comments are made across various files, addressing typographical errors without impacting functionality.

Changes

File Change Summary
.github/config/.codespellignore Added terms: cips, pullrequest, keypair, pastTime, hasTables, Nam, EyT, upTo, initia, minitia, expRes to ignore during spell checking.
.github/workflows/spellcheck.yml Introduced a new GitHub Actions workflow for automated spell checking on pull request events.
app/keepers/keepers.go Corrected comment typo from "propogated" to "propagated" in NewAppKeeper function.
contrib/devtools/Makefile Updated comments for clarity, correcting "will polute the" to "will pollute the" in installation commands.
shared.Dockerfile Corrected comment typo from "editting" to "editing" and streamlined installation commands.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GitHubActions
    participant Codespell
    participant Repository

    User->>Repository: Create Pull Request
    Repository->>GitHubActions: Trigger spellcheck workflow
    GitHubActions->>Codespell: Run spell check
    Codespell->>GitHubActions: Report findings
    GitHubActions->>User: Create Pull Request for corrections (if needed)
Loading

🐰 "In the code where the words did stray,
We fixed the typos, hip-hip-hooray!
With spellcheck now in the fray,
Our comments shine, come what may!
Hopping through code, so neat and bright,
A rabbit's joy in every byte!" 🐇

Warning

Rate limit exceeded

@Vritra4 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4e74655 and 4291e93.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (f43ac99) to head (4291e93).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   75.78%   77.77%   +1.99%     
==========================================
  Files          14       14              
  Lines        1441     1404      -37     
==========================================
  Hits         1092     1092              
+ Misses        302      265      -37     
  Partials       47       47              
Files with missing lines Coverage Δ
app/keepers/keepers.go 97.41% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Outside diff range and nitpick comments (1)
.github/workflows/spellcheck.yml (1)

3-5: Enhance workflow trigger configuration

Consider specifying event types and paths to optimize workflow execution:

 on:
   pull_request:
+    types: [opened, synchronize, reopened]
+    paths-ignore:
+      - '**.md'
+      - 'docs/**'
+      - 'LICENSE'
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4e74655 and 4291e93.

📒 Files selected for processing (5)
  • .github/config/.codespellignore (1 hunks)
  • .github/workflows/spellcheck.yml (1 hunks)
  • app/keepers/keepers.go (1 hunks)
  • contrib/devtools/Makefile (2 hunks)
  • shared.Dockerfile (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • .github/config/.codespellignore
  • app/keepers/keepers.go
  • contrib/devtools/Makefile
  • shared.Dockerfile
🔇 Additional comments (1)
.github/workflows/spellcheck.yml (1)

16-16: Verify .codespellignore configuration

Ensure that .github/config/.codespellignore exists and is properly configured.

✅ Verification successful

Configuration file exists and appears properly configured

The .github/config/.codespellignore file exists and contains a list of words to be ignored by the spellchecker, which is consistent with the workflow configuration. The ignore list includes technical terms and variable names that are valid in the codebase context but might be flagged as spelling errors otherwise.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if .codespellignore exists and show its contents
if [ -f .github/config/.codespellignore ]; then
  echo "Found .codespellignore file:"
  cat .github/config/.codespellignore
else
  echo "Warning: .codespellignore file not found at .github/config/.codespellignore"
fi

Length of output: 228

.github/workflows/spellcheck.yml Show resolved Hide resolved
.github/workflows/spellcheck.yml Show resolved Hide resolved
.github/workflows/spellcheck.yml Show resolved Hide resolved
.github/workflows/spellcheck.yml Show resolved Hide resolved
Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit d27fc24 into main Nov 15, 2024
10 checks passed
@beer-1 beer-1 deleted the chore/spellcheck branch November 15, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants