add timestamp & tx hash to withdrawals #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
beer-1
reviewed
Nov 29, 2024
sh-cha
added a commit
that referenced
this pull request
Dec 10, 2024
* refactor node process * refactor node, broadcaster * refactor provider * refactor merkle, types * refactor db * refactor executor * add migration function * change iterate name & append splitter to key when iterating * add LastProcessedBlockHeightKey migration * only change key if it exists * wrap errors to clarify them * wrap errors on key, provider * wrap errors & merge main * makes log as production & add log-format flag * fix reverse iterate finding prev inclusive start key * db test * db stage test * save finalized tree when it exists * merge cmd * merkle test * merkle types test * host deposit & txhandler test * host handler test * keys test * txutil test * child deposit oracle test * refactor child db and add l2 sequence checker into handleInitiateWithdrawal and test * prepare tree, output test * add version to working tree info & child withdrawal test * child handle output test * child db handler query test * executor types test * format * delete oracle msg data from authz msg & oracle test * update batch info test * batch test * add timestamp & tx hash to withdrawals (#54) * add timestamp & tx hash to withdrawals * fix test and lint * delete last block height --------- Co-authored-by: beer-1 <[email protected]> * format * add batch handler test & fix checkbatch test * add some comments * feat: make stage copiable and introduce allow to customize prefix of db (#56) * make stage copiable and introduce allow to customize prefix of db * add UTC to all time.Unix interface * Update merkle/types/db.go comment Co-authored-by: beer-1 <[email protected]> * simplify delete tree logic * Update merkle/merkle.go comment Co-authored-by: beer-1 <[email protected]> * Update merkle/types/db.go comment Co-authored-by: beer-1 <[email protected]> * Update merkle/db.go Co-authored-by: beer-1 <[email protected]> * Update merkle/types/db.go Co-authored-by: beer-1 <[email protected]> * withdrawal prefix migration * iterate from sequence using start key * use utc time * change ctx name * v0.1.11 migration command * save finalized tree with its value method * coderabbit loop syntax change suggestion * block handler length verification * format * check if tx is inserted to block during waiting time * skip calculating processed heights when nodes have synced height info * get height comments * query block time with block header * Update node/tx_checker.go Co-authored-by: beer-1 <[email protected]> * Update node/tx_checker.go Co-authored-by: beer-1 <[email protected]> * Update challenger/child/withdraw.go Co-authored-by: beer-1 <[email protected]> * iterate future challenges from initial block time as start key * processedEvents typo * Update challenger/handler.go Co-authored-by: beer-1 <[email protected]> * let challenge query use next key * reuse empty batch file function * fix comment * Update node/broadcaster/broadcaster.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix typo * format * Update challenger/query.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * query refactor * Update challenger/query.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update challenger/query.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * error wrapping --------- Co-authored-by: beer-1 <[email protected]> Co-authored-by: beer-1 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
sh-cha
added a commit
that referenced
this pull request
Jan 6, 2025
* refactor node process * refactor node, broadcaster * refactor provider * refactor merkle, types * refactor db * refactor executor * add migration function * change iterate name & append splitter to key when iterating * add LastProcessedBlockHeightKey migration * only change key if it exists * wrap errors to clarify them * wrap errors on key, provider * wrap errors & merge main * makes log as production & add log-format flag * fix reverse iterate finding prev inclusive start key * db test * db stage test * save finalized tree when it exists * merge cmd * merkle test * merkle types test * host deposit & txhandler test * host handler test * keys test * txutil test * child deposit oracle test * refactor child db and add l2 sequence checker into handleInitiateWithdrawal and test * prepare tree, output test * add version to working tree info & child withdrawal test * child handle output test * child db handler query test * executor types test * format * delete oracle msg data from authz msg & oracle test * update batch info test * batch test * add timestamp & tx hash to withdrawals (#54) * add timestamp & tx hash to withdrawals * fix test and lint * delete last block height --------- Co-authored-by: beer-1 <[email protected]> * format * add batch handler test & fix checkbatch test * add some comments * e2e interchaintest setup * add test-e2e to makefile * add syncing query * simple deposit e2e test * syncing query * create connect sidecar container & connect it to l1 * multiple txs e2e test * reconnect node test * batch reconstruction test * tx check err fix * format * bug fix: set bech32 prefix to sdk config before building tx * use celestia custom tx building function * celestia batch reconstruction test * add celestia version to readme * increment page * Update executor/querier.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * sync nil check * check msg type url in msgexec * authz msg length check * authz msg length check * increase timeout of e2e test & add minor comments & add e2e to codecov ignore * address function return decoded address --------- Co-authored-by: beer-1 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.