-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make stage copiable and allow to customize prefix of db #56
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor node process * refactor node, broadcaster * refactor provider * refactor merkle, types * refactor db * refactor executor * add migration function * change iterate name & append splitter to key when iterating * add LastProcessedBlockHeightKey migration * only change key if it exists * wrap errors to clarify them * wrap errors on key, provider * wrap errors & merge main * makes log as production & add log-format flag * fix reverse iterate finding prev inclusive start key * db test * db stage test * save finalized tree when it exists * merge cmd * merkle test * merkle types test * host deposit & txhandler test * host handler test * keys test * txutil test * child deposit oracle test * refactor child db and add l2 sequence checker into handleInitiateWithdrawal and test * prepare tree, output test * add version to working tree info & child withdrawal test * child handle output test * child db handler query test * executor types test * format * delete oracle msg data from authz msg & oracle test * update batch info test * batch test * add timestamp & tx hash to withdrawals (#54) * add timestamp & tx hash to withdrawals * fix test and lint * delete last block height --------- Co-authored-by: beer-1 <[email protected]> * format * add batch handler test & fix checkbatch test * add some comments * feat: make stage copiable and introduce allow to customize prefix of db (#56) * make stage copiable and introduce allow to customize prefix of db * add UTC to all time.Unix interface * Update merkle/types/db.go comment Co-authored-by: beer-1 <[email protected]> * simplify delete tree logic * Update merkle/merkle.go comment Co-authored-by: beer-1 <[email protected]> * Update merkle/types/db.go comment Co-authored-by: beer-1 <[email protected]> * Update merkle/db.go Co-authored-by: beer-1 <[email protected]> * Update merkle/types/db.go Co-authored-by: beer-1 <[email protected]> * withdrawal prefix migration * iterate from sequence using start key * use utc time * change ctx name * v0.1.11 migration command * save finalized tree with its value method * coderabbit loop syntax change suggestion * block handler length verification * format * check if tx is inserted to block during waiting time * skip calculating processed heights when nodes have synced height info * get height comments * query block time with block header * Update node/tx_checker.go Co-authored-by: beer-1 <[email protected]> * Update node/tx_checker.go Co-authored-by: beer-1 <[email protected]> * Update challenger/child/withdraw.go Co-authored-by: beer-1 <[email protected]> * iterate future challenges from initial block time as start key * processedEvents typo * Update challenger/handler.go Co-authored-by: beer-1 <[email protected]> * let challenge query use next key * reuse empty batch file function * fix comment * Update node/broadcaster/broadcaster.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix typo * format * Update challenger/query.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * query refactor * Update challenger/query.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update challenger/query.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * error wrapping --------- Co-authored-by: beer-1 <[email protected]> Co-authored-by: beer-1 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
No description provided.