Update ContextAwareParse to return CommandMatches #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the return type of `ContextAwareParse::parse_input()` was `(Option<Self>, Vec<Self>)` with no real explanation of why. This has now been updated to a properly-documented struct called `CommandMatches<T>`. It also provides convenience functions for converting and combining multiple sets of matches, consolidating some (admittedly simple) logic that was previously scattered all over the place.
MikkelPaulson
force-pushed
the
return-struct-from-context-aware-parse
branch
from
afd8852
to
c0b03ec
Compare
|
@alfonsomartinezs FYI - this should make the parser handling that we paired on a bit more intuitive, at the expense of possibly breaking the draft branch. |
I belatedly realized that `some_vec.drain(..)` is equivalent to `some_vec.into_iter()`, except the latter is more flexible and consumes the input in-place rather than requiring it to be mutable. Every instance of `drain(..)` in the code base was better served by `into_iter()`.
MikkelPaulson
force-pushed
the
return-struct-from-context-aware-parse
branch
from
f7c5532
to
ad04c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the return type of
ContextAwareParse::parse_input()was(Option<Self>, Vec<Self>)with no real explanation of why. This has now been updated to a properly-documented struct calledCommandMatches<T>. It also provides convenience functions for converting and combining multiple sets of matches, consolidating some (admittedly simple) logic that was previously scattered all over the place.Normally I try to keep commits small and numerous in each branch, but this is one of those rip-the-bandaid changes.
Resolves #325.