Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swanky check #114

Closed
5 of 7 tasks
codespool opened this issue Feb 24, 2023 · 3 comments · Fixed by #205
Closed
5 of 7 tasks

Update swanky check #114

codespool opened this issue Feb 24, 2023 · 3 comments · Fixed by #205
Assignees
Labels
enhancement New feature or request

Comments

@codespool
Copy link
Collaborator

codespool commented Feb 24, 2023

Overview (What and Why)

swanky check's output should simply list all the dependencies' versions, and list the eventual missing ones.
It should also include the OS and architecture info.

The output should also be optionally stored in a file, so it can be shared for debugging purposes

We should also maintain a remote compatibility list of cargo-contract version -> min ink! version that should be fetched and used when checking the local env, and warn the user to update the ink! version accordingly

How

  • modify the command output to include install status and versions of all dependencies, including OS
  • add optional file output
  • host a cargo-contract -> ink dependency table
  • fetch and store the dependency table on init and check use
  • check local cargo-contract and contract's ink! versions against the table and warn user to update if needed

Definition of Done

  • above implemented and merged
  • docs updated

Open Issues and Blockers

@codespool codespool added the enhancement New feature or request label Feb 24, 2023
@codespool codespool moved this from 💡 New/Idea to 📋 Backlog (Commited) in Swanky Suite (legacy - moved to swankyhub) Feb 24, 2023
@codespool codespool moved this from 📋 Backlog (Commited) to 🏁 Ready to Start in Swanky Suite (legacy - moved to swankyhub) Apr 14, 2023
@shunsukew
Copy link
Contributor

shunsukew commented Apr 19, 2023

Why not just use redirecting output swanky check > result.txt or use copy&paste?
I don't see any value of saving option.

@codespool
Copy link
Collaborator Author

If you output just plain text, that's an ok option, but if we add some formatting (f.ex. a table or some colours), then a redirect would have unnecessary formatting characters and --file option or similar would be used to print plain text to a file.

@shunsukew shunsukew moved this from 🏁 Ready to Start to 🏗 In progress in Swanky Suite (legacy - moved to swankyhub) Apr 24, 2023
@codespool codespool moved this from 🏗 In progress to 💡 New/Idea in Swanky Suite (legacy - moved to swankyhub) Jul 5, 2023
@codespool codespool moved this from 💡 New/Idea to Proposed by Astar in Swanky Suite (legacy - moved to swankyhub) Jul 5, 2023
This was referenced Jan 15, 2024
@vsofiya vsofiya moved this from Proposed by Astar to 🛠 Ready for review in Treasury Proposal Roadmap - ink!DevHub 1.0 Jan 31, 2024
@vsofiya
Copy link

vsofiya commented Jan 31, 2024

#195

ipapandinas added a commit that referenced this issue Feb 12, 2024
@pmikolajczyk41 pmikolajczyk41 moved this from 🛠 Ready for review to Accepted in Treasury Proposal Roadmap - ink!DevHub 1.0 Feb 22, 2024
ipapandinas added a commit that referenced this issue Mar 25, 2024
ipapandinas added a commit that referenced this issue Mar 25, 2024
@ipapandinas ipapandinas moved this from Accepted to ✅ Done in Treasury Proposal Roadmap - ink!DevHub 1.0 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment