Update swanky check

[prxgr4mm3r]

No description provided.

[ipapandinas]

Checkbox 4 from the original issue #114 is not fully completed:

fetch and store the dependency table on init and check use

We should update node.supportedInk version in swanky config when performing the checkCliDependencies task in the init command. You can make and helper performing the semver.gt against our cargo-contract dependencies map like you did in "Verify ink version" from the check command. Then update the node.supportedInk version in swanky config accordingly.

[prxgr4mm3r]

Checkbox 4 from the original issue #114 is not fully completed:

fetch and store the dependency table on init and check use

We should update node.supportedInk version in swanky config when performing the checkCliDependencies task in the init command. You can make and helper performing the semver.gt against our cargo-contract dependencies map like you did in "Verify ink version" from the check command. Then update the node.supportedInk version in swanky config accordingly.

@ipapandinas Sorry, I don't understand properly what you mean by updating node.supportedInk. I thought that it should be set initially in nodeInfo for every SwankyNode version. Can you explain what factors affect the update of the node.supportedInk?

[ipapandinas]

@prxgr4mm3r you are right node.supportedInk has to be set in nodeInfo and remains static.

Also, I reviewed the UX of the check command, the following tasks have to be perform in this order:

1. "Check OS"
2. "Check Rust"
3. "Check cargo"
4. "Check cargo nightly"
5. "Check cargo dylint"
6. "Check cargo-contract"
7. "Read ink dependencies"
8. "Verify ink version"
   (skipped if no swanky node is installed in swankyConfig)
   ensure compatibility with swanky node: the supportedInk should be greater or equal to the read ink version in step 7
   if not ensured => throw a WARN: Version of ${inkPackage} (${version}) in ${contract} is higher than supported ink version (${supportedInk})
9. "Verify cargo contract version"
   (skipped if no cargo contract installed => tools.cargoContract === null)
   ensure cargo contract version is greater or equal to the minimal version for the read ink version in step 7
10. "Check for missing tools"
    print a console.error([ERROR] ${error}) for each missing tool

So "Check swanky node" becomes useless.

Also additional enhancements:

Try to print versions next to task success messages like this:

✔ Check OS: 'darwin-arm64'
✔ Check Rust: '1.72.1'
✔ Check cargo: '1.72.1'
...
You can extracted them using regex like you did for cargo contract

Also try to throw a WARN instead of error for dylint

✖ Cargo dylint is not installed!

Also checkbox 2 is not implemented

add optional file output

It can be an optional flag --print and the output file should look like this:

{
  "platform": "darwin",
  "architecture": "arm64",
  "tools": {
    "rust": "1.72.1",
    "cargo": "1.72.1",
    "cargoNightly": "1.77.0",
    "cargoContract": "4.0.0-rc.1"
  },
  "missingTools": [],
  "contracts": { "flipper": { "ink": "4.2.1" } },
  "swankyNode": null
}

[pmikolajczyk41]

why was it closed instead of merged? @ipapandinas

[ipapandinas]

I created a single PR #205 to address the overlap between features and to prepare for the upcoming release. I closed this particular one due to significant conflicts. @pmikolajczyk41

[pmikolajczyk41]

@ipapandinas okay, I was just confused that the other 3 PRs were merged, so I wanted to ensure - thanks!