Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grammar and Spelling Issues #251

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Madmaxs2
Copy link

Changes Made

1. src/components/ThemeToggle.tsx

Comment Update:

  • Old: "This is not ideal, but it's best solution we have..."
  • New: "This is not ideal, but it's the best solution we have..."

Reason: Added missing article "the" to improve grammatical correctness in the comment.

2. src/components/Toc.tsx

Import Statement Update:

  • Old: import { ThumpUpIcon } from "@/icons/ThumpUp";
  • New: import { ThumbUpIcon } from "@/icons/ThumbUp";

Reason: Fixed spelling error in component name and file path. "Thumb" (meaning the finger) was incorrectly spelled as "Thump".

Summary

These changes improve code quality by:

  1. Fixing grammatical issues in documentation comments
  2. Correcting spelling mistakes in component names and file paths
  3. Maintaining consistency in naming conventions

@Madmaxs2 Madmaxs2 requested a review from a team as a code owner November 26, 2024 20:28
@@ -1,7 +1,7 @@
import Link from "next/link";

import { PencilIcon } from "@/icons/Pencil";
import { ThumpUpIcon } from "@/icons/ThumpUp";
import { ThumbUpIcon } from "@/icons/ThumbUp";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This file will also need to be renamed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This file will also need to be renamed

#255

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants