Merge pull request #35 from inovex/add-golangci-lint

Add golangci lint

.github/workflows/go.yml

@@ -11,11 +11,23 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.15
+        go-version: 1.14
       id: go
 
-    - name: Check out code into the Go module directory
-      uses: actions/checkout@v1
+    - name: Check out code
+      uses: actions/checkout@v2
+
+    - name: Go vet
+      run: go vet
 
     - name: Build
       run: make all
+
+  linting:
+    name: Linting
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Run golangci-lint
+        uses: actions-contrib/golangci-lint@v1

main.go

@@ -16,10 +16,9 @@ import (
 )
 
 var (
-	resultChan         = make(chan Result)
-	stopWaitLoop       = false
-	tearDownInProgress = false
-	randomSource       = rand.New(rand.NewSource(time.Now().UnixNano()))
+	resultChan   = make(chan Result)
+	stopWaitLoop = false
+	randomSource = rand.New(rand.NewSource(time.Now().UnixNano()))
 
 	subscriberClientIdTemplate = "mqtt-stresser-sub-%s-worker%d-%d"
 	publisherClientIdTemplate  = "mqtt-stresser-pub-%s-worker%d-%d"
@@ -134,7 +133,7 @@ func main() {
 
 	actionTimeout, err := time.ParseDuration(*argTimeout)
 	if err != nil {
-		fmt.Fprintln(os.Stderr, "Could not parse '--timeout': '%s' is not a valid duration string. See https://golang.org/pkg/time/#ParseDuration for valid duration strings\n", *argGlobalTimeout)
+		fmt.Fprintf(os.Stderr, "Could not parse '--timeout': '%s' is not a valid duration string. See https://golang.org/pkg/time/#ParseDuration for valid duration strings\n", *argGlobalTimeout)
 		os.Exit(1)
 	}
 
@@ -269,7 +268,7 @@ func main() {
 				errorLogger.Println(msg)
 			}
 
-			if *argHideProgress == false {
+			if !*argHideProgress {
 				if msg.Event == CompletedEvent {
 					fmt.Print(".")
 				}

report.go

@@ -195,7 +195,7 @@ func buildHistogram(series []float64, total int) map[float64]float64 {
 		keys = append(keys, k)
 	}
 
-	sort.Sort(sort.Float64Slice(keys))
+	sort.Float64s(keys)
 	histogram := make(map[float64]float64)
 
 	prev := 0.0