-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Added custom DisableCallUserFuncSniff (with tests) - Added custom DisableMagicSerializeSniff (with tests) - Added custom NoRootNamespaceFunctionsSniff (with tests) - Added Slevomat standard as dependency - Explicilty required PHPCSExtra and PHPCS Utils - Replaced some Netron sniffs with Generic/Squid/PHPCSExtra/Slevomat - Renamed updated WPCS standards - Improved QA
- Loading branch information
Showing
15 changed files
with
365 additions
and
167 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * This file is part of the "php-coding-standards" package. | ||
| * | ||
| * Copyright (C) 2023 Inpsyde GmbH | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU General Public License | ||
| * as published by the Free Software Foundation; either version 2 | ||
| * of the License, or (at your option) any later version. | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program; if not, write to the Free Software | ||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Inpsyde\Sniffs\CodeQuality; | ||
|
|
||
| use WordPressCS\WordPress\AbstractFunctionRestrictionsSniff; | ||
|
|
||
| class DisableCallUserFuncSniff extends AbstractFunctionRestrictionsSniff | ||
| { | ||
| /** | ||
| * @return array<string, array<string, string|array>> | ||
| * | ||
| * phpcs:disable Inpsyde.CodeQuality.NoAccessors | ||
| */ | ||
| public function getGroups(): array | ||
| { | ||
| // phpcs:enable Inpsyde.CodeQuality.NoAccessors | ||
| return [ | ||
| 'call_user_func' => [ | ||
| 'type' => 'error', | ||
| 'message' => 'Usage of %s() is forbidden.', | ||
| 'functions' => [ | ||
| 'call_user_func', | ||
| 'call_user_func_array', | ||
| 'suca', | ||
| ], | ||
| ], | ||
| ]; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * This file is part of the "php-coding-standards" package. | ||
| * | ||
| * Copyright (C) 2023 Inpsyde GmbH | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU General Public License | ||
| * as published by the Free Software Foundation; either version 2 | ||
| * of the License, or (at your option) any later version. | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program; if not, write to the Free Software | ||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Inpsyde\Sniffs\CodeQuality; | ||
|
|
||
| use PHP_CodeSniffer\Files\File; | ||
| use PHP_CodeSniffer\Sniffs\Sniff; | ||
| use PHPCSUtils\Utils\FunctionDeclarations; | ||
| use PHPCSUtils\Utils\Scopes; | ||
|
|
||
| class DisableMagicSerializeSniff implements Sniff | ||
| { | ||
| /** @var list<string> */ | ||
| public array $disabledFunctions = [ | ||
| '__serialize', | ||
| '__sleep', | ||
| '__unserialize', | ||
| '__wakeup', | ||
| ]; | ||
|
|
||
| /** | ||
| * @return list<int> | ||
| */ | ||
| public function register(): array | ||
| { | ||
| return [T_FUNCTION]; | ||
| } | ||
|
|
||
| /** | ||
| * @param File $phpcsFile | ||
| * @param int $stackPtr | ||
| * @return void | ||
| * | ||
| * phpcs:disable Inpsyde.CodeQuality.ArgumentTypeDeclaration | ||
| */ | ||
| public function process(File $phpcsFile, $stackPtr) | ||
| { | ||
| // phpcs:enable Inpsyde.CodeQuality.ArgumentTypeDeclaration | ||
| if (!Scopes::isOOMethod($phpcsFile, $stackPtr)) { | ||
| return; | ||
| } | ||
|
|
||
| $name = FunctionDeclarations::getName($phpcsFile, $stackPtr); | ||
| if (in_array($name, $this->disabledFunctions, true)) { | ||
| $phpcsFile->addError( | ||
| sprintf( | ||
| 'The method "%s" is forbidden, please use Serializable interface.', | ||
| $name | ||
| ), | ||
| $stackPtr, | ||
| 'Found' | ||
| ); | ||
| } | ||
| } | ||
| } |
71 changes: 71 additions & 0 deletions
71
Inpsyde/Sniffs/CodeQuality/NoRootNamespaceFunctionsSniff.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * This file is part of the "php-coding-standards" package. | ||
| * | ||
| * Copyright (C) 2023 Inpsyde GmbH | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU General Public License | ||
| * as published by the Free Software Foundation; either version 2 | ||
| * of the License, or (at your option) any later version. | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program; if not, write to the Free Software | ||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Inpsyde\Sniffs\CodeQuality; | ||
|
|
||
| use PHP_CodeSniffer\Files\File; | ||
| use PHP_CodeSniffer\Sniffs\Sniff; | ||
| use PHPCSUtils\Utils\FunctionDeclarations; | ||
| use PHPCSUtils\Utils\Namespaces; | ||
| use PHPCSUtils\Utils\ObjectDeclarations; | ||
| use PHPCSUtils\Utils\Scopes; | ||
|
|
||
| class NoRootNamespaceFunctionsSniff implements Sniff | ||
| { | ||
| /** | ||
| * @return list<int> | ||
| */ | ||
| public function register(): array | ||
| { | ||
| return [T_FUNCTION]; | ||
| } | ||
|
|
||
| /** | ||
| * @param File $phpcsFile | ||
| * @param int $stackPtr | ||
| * @return void | ||
| * | ||
| * phpcs:disable Inpsyde.CodeQuality.ArgumentTypeDeclaration | ||
| */ | ||
| public function process(File $phpcsFile, $stackPtr): void | ||
| { | ||
| // phpcs:enable Inpsyde.CodeQuality.ArgumentTypeDeclaration | ||
| if (Scopes::isOOMethod($phpcsFile, $stackPtr)) { | ||
| return; | ||
| } | ||
|
|
||
| $namespace = Namespaces::determineNamespace($phpcsFile, $stackPtr); | ||
| if ($namespace !== '') { | ||
| return; | ||
| } | ||
| $name = FunctionDeclarations::getName($phpcsFile, $stackPtr); | ||
| if (!$name) { | ||
| return; | ||
| } | ||
|
|
||
| $message = sprintf('The function "%s" is in root namespace.', $name); | ||
|
|
||
| $phpcsFile->addError($message, $stackPtr, 'Found'); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.