-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #66
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tangrufus
requested changes
Aug 25, 2023
The feature branch we were using has been merged.
gmazzap
approved these changes
Aug 25, 2023
@antonioeatgoat Already updated the requirement for
Now I think this is mergiable. |
3 tasks
@antonioeatgoat @tangrufus We'll need to release is a nww major, so I created the |
This has been merged into #62 so I'm closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Dependencies update
What is the current behavior?
Current dependencies doesn't support PHP 8
What is the new behavior?
The new dependencies support PHP 8
Does this PR introduce a breaking change?
Yes. As described here, the name of some rules of WorrdPress Coding Standards are changed and so any direct referral (for instance `phpcs:ignore RULE_NAME) would not work anymore.