Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #66

Closed
wants to merge 9 commits into from
Closed

Update dependencies #66

wants to merge 9 commits into from

Conversation

antonioeatgoat
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce?
Dependencies update

What is the current behavior?
Current dependencies doesn't support PHP 8

What is the new behavior?
The new dependencies support PHP 8

Does this PR introduce a breaking change?
Yes. As described here, the name of some rules of WorrdPress Coding Standards are changed and so any direct referral (for instance `phpcs:ignore RULE_NAME) would not work anymore.

@antonioeatgoat antonioeatgoat linked an issue Aug 25, 2023 that may be closed by this pull request
1 task
composer.json Outdated Show resolved Hide resolved
@gmazzap gmazzap requested a review from tangrufus August 25, 2023 22:30
@gmazzap
Copy link
Contributor

gmazzap commented Aug 25, 2023

@antonioeatgoat Already updated the requirement for automattic/vipwpcs as requested by @tangrufus

  • Optimized dependencies to reduce conflicts and for PHP 7.4+
  • Fixed tests failing because usage of changed PHPCS API
  • Made use of Inpsyde reusable workflow for tests

Now I think this is mergiable.

@gmazzap gmazzap mentioned this pull request Aug 25, 2023
3 tasks
@gmazzap gmazzap changed the base branch from master to version/2 August 25, 2023 22:44
@gmazzap
Copy link
Contributor

gmazzap commented Aug 25, 2023

@antonioeatgoat @tangrufus We'll need to release is a nww major, so I created the version/2 branch and changed the base branch to that.

@gmazzap
Copy link
Contributor

gmazzap commented Aug 25, 2023

This has been merged into #62 so I'm closing this

@gmazzap gmazzap closed this Aug 25, 2023
@gmazzap gmazzap deleted the feature/64 branch August 25, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update dependencies to be compatible with PHP 8
3 participants