This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-393] Fix segfault in cryptonite #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
force-pushed
the
devops-293-fix-cryptonite-segfault
branch
2 times, most recently
from
6b461ca to
cf75c11
Compare
domenkozar
changed the title
dcoutts
previously approved these changes
Oct 1, 2017
There was a problem hiding this comment.
I'm ok with this for now but I'd like to gain a full understanding of it.
Posted my concerns here on the upstream issue.
haskell-crypto/cryptonite#193 (comment)
domenkozar
force-pushed
the
devops-293-fix-cryptonite-segfault
branch
from
cf75c11 to
601adb3
Compare
See upstream issue at haskell-crypto/cryptonite#193
domenkozar
force-pushed
the
devops-293-fix-cryptonite-segfault
branch
from
601adb3 to
9f61525
Compare
dcoutts
approved these changes
Oct 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See upstream issue at haskell-crypto/cryptonite#193