Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kroki.io broken service prevents ci from passing #200

Merged
merged 81 commits into from
Mar 8, 2024

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Mar 8, 2024

Description

Kroki is breaking CI
This PR disables Kroki altogether and enables a replacement for rendering graphviz documents.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Closes #202

@stevenj stevenj enabled auto-merge (squash) March 8, 2024 09:51
@stevenj stevenj added the bug Something isn't working label Mar 8, 2024
@stevenj stevenj self-assigned this Mar 8, 2024
earthly/rust/Earthfile Outdated Show resolved Hide resolved
@stevenj stevenj requested a review from Mr-Leshiy March 8, 2024 11:51
Copy link

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 7ede49e into master Mar 8, 2024
65 checks passed
@stevenj stevenj deleted the fix/kroki-broken-with-graphviz branch March 8, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: CI is broken because kroki.io is unreliable and is failing docs being built
4 participants