Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): TagSelection #1455

Merged
merged 17 commits into from
Jan 7, 2025
Merged

feat(cat-voices): TagSelection #1455

merged 17 commits into from
Jan 7, 2025

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Jan 2, 2025

Description

This PR adds single tag selection definition widget

Related Issue(s)

Resolves #1417

Description of Changes

Other then SingleGroupedTagSelectorWidget

  • starred String extension. Useful when working adding prefix to sections names.
  • VoicesDropdownFormField and extracted VoicesInputDecorationTheme. In future we should refactor VoicesTextField so it depends on theme more.
  • GroupedTags helper class for easier work with Document oneOf properties.
  • DocumentSchemaPropertyDto now declares just once includeIfNull: false instead of for every property.

Demo

Screen.Recording.2025-01-07.at.10.08.24.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added ux/ui UX/UI related issues dart Pull requests that update Dart code labels Jan 2, 2025
@damian-molinski damian-molinski self-assigned this Jan 2, 2025
@damian-molinski damian-molinski added the do not review yet Do not review yet label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Test Report | ${\color{lightgreen}Pass: 372/372}$ | ${\color{red}Fail: 0/372}$ |

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Test Report | ${\color{lightgreen}Pass: 379/379}$ | ${\color{red}Fail: 0/379}$ |

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 372/372}$ | ${\color{red}Fail: 0/372}$ |

@damian-molinski damian-molinski added review me PR is ready for review and removed do not review yet Do not review yet labels Jan 7, 2025
@damian-molinski damian-molinski marked this pull request as ready for review January 7, 2025 09:19
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Report | ${\color{lightgreen}Pass: 372/372}$ | ${\color{red}Fail: 0/372}$ |

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Report | ${\color{lightgreen}Pass: 372/372}$ | ${\color{red}Fail: 0/372}$ |

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

@dtscalac
Copy link
Contributor

dtscalac commented Jan 7, 2025

Merging this PR, the failure is unrelated to these changes.

@dtscalac dtscalac merged commit b1e249d into main Jan 7, 2025
36 of 39 checks passed
@dtscalac dtscalac deleted the feat/tag_selection_1417 branch January 7, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : User Input Component - Tag Selection
2 participants