Add better support for armv7a cross compilation #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angerman
force-pushed
the
armv7a
branch
2 times, most recently
from
ad387e1 to
07d382f
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@angerman are you still interested in this? |
|
I'm afraid yes. |
This adds support to haskell.nix for building for armv7a-android. It includes - various minor fixes - a lot of bionic (libc) patches for ghc - no gold on 32bit android - android overlay: mostly static - disable KTLS on openssl for android
* android: missing patches * ios: missing patches
cabal ends up with aarch64-android whereas hadrian ends up with aarch64-linux_android
GenApply suffers from having GHC pollute its defines.
This is added for aarch64 for now only as that's the only affeted platform.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,4 +1,21 @@ | |||
| _final: prev: prev.lib.optionalAttrs prev.stdenv.hostPlatform.isAndroid ({ | |||
| final: prev: { | |||
There was a problem hiding this comment.
[diff] reported by reviewdog 🐶
Suggested change
| final: prev: { | |
| _final: prev: { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: