1176 remove Show Warnings from modules (#273)

Part of insightsengineering/teal#1176
insightsengineering · May 10, 2024 · b583826 · b583826
1 parent eee056f
commit b583826
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 48 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # teal.goshawk 0.1.15.9018
 
+* Removed `Show Warnings` modals from modules.
+
 ### Breaking Changes
 * Adapted all modules to use `teal_data` objects.
 

diff --git a/R/tm_g_gh_boxplot.R b/R/tm_g_gh_boxplot.R
@@ -297,7 +297,6 @@ ui_g_boxplot <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = a$pre_output,
@@ -587,13 +586,6 @@ srv_g_boxplot <- function(id,
       teal.code::join(create_plot(), create_table())
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(joined_qenvs())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(joined_qenvs())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(joined_qenvs())),

diff --git a/R/tm_g_gh_correlationplot.R b/R/tm_g_gh_correlationplot.R
@@ -352,7 +352,6 @@ ui_g_correlationplot <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = a$pre_output,
@@ -890,13 +889,6 @@ srv_g_correlationplot <- function(id,
         DT::formatRound(numeric_cols, 4)
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(plot_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(plot_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(plot_q())),

diff --git a/R/tm_g_gh_density_distribution_plot.R b/R/tm_g_gh_density_distribution_plot.R
@@ -242,7 +242,6 @@ ui_g_density_distribution_plot <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = a$pre_output,
@@ -419,13 +418,6 @@ srv_g_density_distribution_plot <- function(id, # nolint
       teal.code::join(create_plot(), create_table())
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(joined_qenvs())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(joined_qenvs())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(

diff --git a/R/tm_g_gh_lineplot.R b/R/tm_g_gh_lineplot.R
@@ -298,7 +298,6 @@ ui_lineplot <- function(id, ...) {
         )
       ),
       forms = tagList(
-        teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
         teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
       ),
       pre_output = a$pre_output,
@@ -784,13 +783,6 @@ srv_lineplot <- function(id,
     }
     ###
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(plot_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(plot_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(plot_q())),

diff --git a/R/tm_g_gh_scatterplot.R b/R/tm_g_gh_scatterplot.R
@@ -241,7 +241,6 @@ ui_g_scatterplot <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = a$pre_output,
@@ -434,13 +433,6 @@ srv_g_scatterplot <- function(id,
         DT::formatRound(numeric_cols, 4)
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(plot_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(plot_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(plot_q())),

diff --git a/R/tm_g_gh_spaghettiplot.R b/R/tm_g_gh_spaghettiplot.R
@@ -308,7 +308,6 @@ g_ui_spaghettiplot <- function(id, ...) {
         )
       ),
       forms = tagList(
-        teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
         teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
       ),
       pre_output = a$pre_output,
@@ -549,13 +548,6 @@ srv_g_spaghettiplot <- function(id,
         DT::formatRound(numeric_cols, 4)
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(plot_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(plot_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(plot_q())),