Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

227 utilize logger::log_shiny_input_change #1182

Merged
merged 20 commits into from
May 16, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented May 9, 2024

Close #227

Similar to insightsengineering/teal.modules.general#750

Code used to generate mass changes:

files <- list.files('R', full.names = TRUE)
for(file in files) {
  content <- readLines(file)
  mod_line <- grep('moduleServer(', content, fixed = TRUE)
  if (length(mod_line) > 0) {
    new_content <- c(
      content[1:mod_line],
      'logger::log_shiny_input_changes(input, namespace = "teal.modules.clinical")',
      content[(mod_line+1):length(content)]
    )
    writeLines(new_content, file)
  }
  
}

@m7pr m7pr added the core label May 9, 2024
@m7pr m7pr requested a review from pawelru May 9, 2024 10:08
@m7pr
Copy link
Contributor Author

m7pr commented May 9, 2024

Waiting for CI/CD to style files

Copy link
Contributor

github-actions bot commented May 9, 2024

Unit Tests Summary

    1 files     70 suites   1h 4m 6s ⏱️
  720 tests   610 ✅ 110 💤 0 ❌
1 983 runs  1 761 ✅ 222 💤 0 ❌

Results for commit e9a445b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 10, 2024

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $119.69$ $+8.07$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $498.59$ $+79.27$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $206.27$ $+17.17$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $95.60$ $+8.83$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $157.71$ $+7.98$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💔 $57.87$ $+4.34$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $96.81$ $+7.49$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $217.45$ $+21.51$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $78.78$ $+6.55$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $114.49$ $+14.70$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $182.80$ $+19.80$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $165.14$ $+25.00$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $77.19$ $+3.47$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $58.57$ $+6.64$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $61.07$ $+11.47$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $85.19$ $+4.58$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $69.08$ $+4.71$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💔 $66.52$ $+3.06$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💔 $54.48$ $+2.13$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $82.74$ $+2.80$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_patyear 💔 $38.21$ $+1.46$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $57.06$ $+3.44$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $70.23$ $+9.46$ $0$ $0$ $0$ $0$
shinytest2-tm_t_logistic 💔 $53.34$ $+2.99$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💔 $51.89$ $+2.08$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_basic_info 💔 $33.24$ $+3.24$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $100.17$ $+17.31$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_medical_history 💔 $59.82$ $+3.38$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $70.83$ $+7.83$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $52.30$ $+3.05$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $82.49$ $+4.57$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $71.17$ $+8.04$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $52.00$ $+2.56$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary 💔 $34.97$ $+1.23$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $72.53$ $+2.89$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💔 $58.35$ $+4.40$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💔 $8.76$ $+1.56$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.71$ $+1.26$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $8.28$ $+1.39$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.49$ $+1.31$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm 💔 $8.79$ $+1.47$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.80$ $+1.18$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $8.23$ $+1.26$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_method_t_mmrm_cov.
shinytest2-tm_a_mmrm 💔 $8.24$ $+1.08$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.31$ $+1.36$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm 💔 $8.69$ $+1.40$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.64$ $+1.40$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $8.17$ $+1.37$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_method_t_mmrm_cov.
shinytest2-tm_a_mmrm 💔 $8.24$ $+1.29$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.11$ $+1.31$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm 💔 $8.05$ $+1.07$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_method_t_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $8.71$ $+1.60$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.66$ $+1.45$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $8.26$ $+1.16$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_method_t_mmrm_cov.
shinytest2-tm_a_mmrm 💔 $8.34$ $+1.25$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.48$ $+1.18$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm 💔 $8.79$ $+1.35$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.94$ $+1.12$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $8.26$ $+1.25$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_method_t_mmrm_cov.
shinytest2-tm_a_mmrm 💔 $8.39$ $+1.00$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.37$ $+1.15$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm 💔 $8.15$ $+1.07$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_method_t_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $8.68$ $+1.57$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.65$ $+1.33$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $8.28$ $+1.16$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_method_t_mmrm_cov.
shinytest2-tm_a_mmrm 💔 $8.32$ $+1.22$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $8.46$ $+1.02$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm 💔 $9.59$ $+1.01$ e2e_tm_a_mmrm_Function_g_mmrm_diagnostic_selection_shows_output_settings_changing_settings_throws_no_validation_errors_and_verify_visibility_of_generated_plots.
shinytest2-tm_a_mmrm 💔 $12.87$ $+1.80$ e2e_tm_a_mmrm_Function_g_mmrm_lsmeans_selection_shows_output_settings_changing_settings_throws_no_validation_errors_and_verify_visibility_of_generated_plots.
shinytest2-tm_a_mmrm 💔 $17.18$ $+2.79$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $26.12$ $+5.48$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💔 $24.21$ $+5.24$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_cov.
shinytest2-tm_a_mmrm 💔 $24.38$ $+5.31$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💔 $25.41$ $+5.17$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm 💔 $26.52$ $+5.64$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.
shinytest2-tm_g_barchart_simple 💔 $8.85$ $+1.30$ e2e_tm_g_barchart_simple_Changing_label_bars_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 💔 $8.80$ $+1.21$ e2e_tm_g_barchart_simple_Selection_of_x_changes_the_element_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 💔 $8.49$ $+1.22$ e2e_tm_g_km_Changing_arm_var_changes_the_plot_without_errors.
shinytest2-tm_g_km 💔 $9.02$ $+1.07$ e2e_tm_g_km_Changing_facet_var_changes_the_plot_without_errors.
shinytest2-tm_g_km 💔 $7.58$ $+1.22$ e2e_tm_g_km_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_pp_adverse_events 💔 $7.39$ $+1.45$ e2e_tm_g_pp_adverse_events_Selecting_action_column_doesn_t_throw_errors_and_changes_the_plot_and_table.
shinytest2-tm_g_pp_adverse_events 💔 $7.31$ $+1.24$ e2e_tm_g_pp_adverse_events_Selecting_aeterm_column_doesn_t_throw_errors_and_changes_the_plot_and_table.
shinytest2-tm_g_pp_adverse_events 💔 $7.28$ $+1.36$ e2e_tm_g_pp_adverse_events_Selecting_causality_column_doesn_t_throw_errors_and_changes_the_plot_and_table.
shinytest2-tm_g_pp_adverse_events 💔 $7.33$ $+1.25$ e2e_tm_g_pp_adverse_events_Selecting_outcome_column_doesn_t_throw_errors_and_changes_the_plot_and_table.
shinytest2-tm_g_pp_adverse_events 💔 $7.65$ $+1.07$ e2e_tm_g_pp_adverse_events_Selecting_patient_id_doesn_t_throw_errors_and_changes_the_plot_and_table.
shinytest2-tm_g_pp_adverse_events 💔 $7.46$ $+1.48$ e2e_tm_g_pp_adverse_events_Selecting_time_column_doesn_t_throw_errors_and_changes_the_plot_and_table.
shinytest2-tm_g_pp_adverse_events 💔 $7.37$ $+1.41$ e2e_tm_g_pp_adverse_events_Selecting_tox_grade_column_doesn_t_throw_errors_and_changes_the_plot_and_table.
shinytest2-tm_g_pp_patient_timeline 💔 $7.42$ $+1.42$ e2e_tm_g_pp_patient_timeline_Deselecting_dstime_end_throws_validation_error.
shinytest2-tm_g_pp_patient_timeline 💔 $7.89$ $+1.06$ e2e_tm_g_pp_patient_timeline_Selecting_aetime_end_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_pp_patient_timeline 💔 $7.71$ $+1.24$ e2e_tm_g_pp_patient_timeline_Selecting_aetime_start_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_pp_patient_timeline 💔 $7.82$ $+1.12$ e2e_tm_g_pp_patient_timeline_Selecting_dstime_end_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.28$ $+1.30$ e2e_tm_g_pp_therapy_Changing_font_size_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.07$ $+1.11$ e2e_tm_g_pp_therapy_Deselection_of_cmendy_throws_validation_error.
shinytest2-tm_g_pp_therapy 💔 $7.00$ $+1.02$ e2e_tm_g_pp_therapy_Deselection_of_cmstdy_throws_validation_error.
shinytest2-tm_g_pp_therapy 💔 $7.40$ $+1.18$ e2e_tm_g_pp_therapy_Selection_of_atirel_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.35$ $+1.28$ e2e_tm_g_pp_therapy_Selection_of_cmdecod_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.42$ $+1.26$ e2e_tm_g_pp_therapy_Selection_of_cmdose_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.36$ $+1.41$ e2e_tm_g_pp_therapy_Selection_of_cmdosfrq_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.32$ $+1.40$ e2e_tm_g_pp_therapy_Selection_of_cmdosu_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.34$ $+1.58$ e2e_tm_g_pp_therapy_Selection_of_cmendy_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.38$ $+1.26$ e2e_tm_g_pp_therapy_Selection_of_cmindc_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.43$ $+1.13$ e2e_tm_g_pp_therapy_Selection_of_cmroute_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.36$ $+1.49$ e2e_tm_g_pp_therapy_Selection_of_cmstdy_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_g_pp_therapy 💔 $7.35$ $+1.21$ e2e_tm_g_pp_therapy_Selection_of_patient_id_changes_the_plot_and_table_without_any_validation_errors.
shinytest2-tm_t_abnormality_by_worst_grade 💔 $8.00$ $+1.27$ e2e_tm_t_abnormality_by_worst_grade_Changing_add_total_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_abnormality_by_worst_grade 💔 $7.94$ $+1.60$ e2e_tm_t_abnormality_by_worst_grade_Changing_drop_arm_levels_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_abnormality_by_worst_grade 💔 $7.54$ $+1.30$ e2e_tm_t_abnormality_by_worst_grade_Deselection_of_arm_var_throws_validation_error.
shinytest2-tm_t_abnormality_by_worst_grade 💔 $7.52$ $+1.33$ e2e_tm_t_abnormality_by_worst_grade_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_t_abnormality_by_worst_grade 💔 $6.88$ $+1.38$ e2e_tm_t_abnormality_by_worst_grade_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_t_abnormality_by_worst_grade 💔 $7.99$ $+1.49$ e2e_tm_t_abnormality_by_worst_grade_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_abnormality_by_worst_grade 💔 $7.83$ $+1.67$ e2e_tm_t_abnormality_by_worst_grade_Selecting_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_abnormality_by_worst_grade 💔 $7.37$ $+1.44$ e2e_tm_t_abnormality_by_worst_grade_Starts_with_specified_label_arm_var_paramcd_id_var_atoxgr_var_worst_high_flag_var_worst_low_flag_var_worst_flag_indicator_add_total_drop_arm_levels.
shinytest2-tm_t_exposure 💔 $6.87$ $+1.06$ e2e_tm_t_exposure_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_t_exposure 💔 $6.88$ $+1.10$ e2e_tm_t_exposure_Deselection_of_parcat_throws_validation_error.
shinytest2-tm_t_exposure 💔 $7.36$ $+1.10$ e2e_tm_t_exposure_Selecting_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_pp_laboratory 💔 $6.39$ $+1.55$ e2e_tm_t_pp_laboratory_Selecting_arind_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_pp_laboratory 💔 $6.43$ $+1.55$ e2e_tm_t_pp_laboratory_Selecting_aval_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_pp_laboratory 💔 $6.38$ $+1.63$ e2e_tm_t_pp_laboratory_Selecting_avalu_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_pp_laboratory 💔 $6.34$ $+1.62$ e2e_tm_t_pp_laboratory_Selecting_param_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_pp_laboratory 💔 $6.16$ $+1.27$ e2e_tm_t_pp_laboratory_Selecting_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_pp_laboratory 💔 $6.38$ $+1.02$ e2e_tm_t_pp_laboratory_Selecting_patient_id_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_pp_laboratory 💔 $6.31$ $+1.67$ e2e_tm_t_pp_laboratory_Selecting_timepoints_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_shift_by_grade 💔 $8.53$ $+1.06$ e2e_tm_t_shift_by_grade_Deselection_of_arm_var_throws_validation_error.
shinytest2-tm_t_shift_by_grade 💔 $8.41$ $+1.10$ e2e_tm_t_shift_by_grade_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_t_shift_by_grade 💔 $8.48$ $+1.12$ e2e_tm_t_shift_by_grade_Deselection_of_worst_flag_throws_validation_error.
shinytest2-tm_t_shift_by_grade 💔 $10.27$ $+1.05$ e2e_tm_t_shift_by_grade_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_shift_by_grade 💔 $10.17$ $+1.10$ e2e_tm_t_shift_by_grade_Selecting_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_summary_by 💔 $22.80$ $+1.13$ e2e_tm_t_summary_by_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit da73d2e

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented May 16, 2024

Created an issue, for the future, to keep in mind that the if statement might not be needed anymore at some point #1185

@m7pr m7pr enabled auto-merge (squash) May 16, 2024 10:55
@m7pr m7pr merged commit bdf6a71 into main May 16, 2024
28 checks passed
@m7pr m7pr deleted the 239_log_shiny_input_change@main branch May 16, 2024 12:18
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logger::log_shiny_input_changes once it allows to log to a custom namespace
2 participants