Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1176 remove Show Warnings from modules #749

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented May 8, 2024

@m7pr m7pr added the core label May 8, 2024
@m7pr m7pr requested a review from pawelru May 8, 2024 10:08
@m7pr m7pr changed the title 1176 remove `Show Warnings from modules 1176 remove Show Warnings from modules May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@m7pr
Copy link
Contributor Author

m7pr commented May 8, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented May 8, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    826     826  0.00%    108-1066
R/tm_a_regression.R             772     772  0.00%    153-1029
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            329     329  0.00%    135-535
R/tm_g_bivariate.R              671     409  39.05%   303-767, 808, 919, 936, 954, 965-987
R/tm_g_distribution.R          1049    1049  0.00%    122-1309
R/tm_g_response.R               350     350  0.00%    154-576
R/tm_g_scatterplot.R            721     721  0.00%    230-1051
R/tm_g_scatterplotmatrix.R      277     258  6.86%    165-470, 531, 545
R/tm_missing_data.R            1068    1068  0.00%    92-1315
R/tm_outliers.R                 984     984  0.00%    134-1261
R/tm_t_crosstable.R             250     250  0.00%    141-438
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8715    8415  3.44%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/tm_a_pca.R                     -7      -7  +100.00%
R/tm_a_regression.R              -7      -7  +100.00%
R/tm_g_association.R             -7      -7  +100.00%
R/tm_g_bivariate.R               -7      -7  +0.40%
R/tm_g_distribution.R            -7      -7  +100.00%
R/tm_g_response.R                -7      -7  +100.00%
R/tm_g_scatterplot.R             -7      -7  +100.00%
R/tm_g_scatterplotmatrix.R       -7      -7  +0.17%
R/tm_missing_data.R              -7      -7  +100.00%
R/tm_outliers.R                  -7      -7  +100.00%
R/tm_t_crosstable.R              -7      -7  +100.00%
TOTAL                           -77     -77  +0.03%

Results for commit: f2959be

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 8, 2024

Unit Tests Summary

  1 files   22 suites   10m 23s ⏱️
147 tests 147 ✅ 0 💤 0 ❌
478 runs  478 ✅ 0 💤 0 ❌

Results for commit f2959be.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 8, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_pca 💚 $98.89$ $-4.26$ $0$ $0$ $0$ $0$
shinytest2-tm_a_regression 💚 $42.52$ $-1.09$ $0$ $0$ $0$ $0$
shinytest2-tm_g_bivariate 💚 $44.28$ $-1.57$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $73.51$ $-1.67$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💚 $85.02$ $-1.92$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💚 $49.64$ $-2.33$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_variable_browser 💚 $8.70$ $-1.01$ e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers.

Results for commit d07b128

♻️ This comment has been updated with latest results.

Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! no more occurrence of teal.code::get_warnings(). Could you please add a news entry for this?

@m7pr m7pr enabled auto-merge (squash) May 10, 2024 08:58
@m7pr m7pr merged commit bc597d4 into main May 10, 2024
28 checks passed
@m7pr m7pr deleted the 1176_remove_show_warnings@main branch May 10, 2024 09:14
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants