Ensures required packages are in Imports section #774
Conversation
|
Code Coverage SummaryDiff against mainResults for commit: 27a75ad Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 22 suites 12m 50s ⏱️ Results for commit 27a75ad. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit bab0579 ♻️ This comment has been updated with latest results. |
| @@ -44,6 +44,7 @@ test_that("e2e - tm_data_table: Verify checkbox displayed over data table", { | |||
| }) | |||
|
|
|||
| test_that("e2e - tm_data_table: Verify module displays data table", { | |||
| testthat::skip_if_not_installed("rvest") | |||
There was a problem hiding this comment.
I have recently pushed changes into the teal due to noSuggest check and the class definition looks like this:
https://github.com/insightsengineering/teal/blob/7eac4d58a5373aa511f363a2f259d850749501f7/R/TealAppDriver.R#L10-L20
Just thinking loud now, would it help if we would have the following instead?
if (!requireNamespace("shinytest2", quietly = TRUE)) {
if (requireNamespace("testthat", quietly = TRUE) && getNamespace("testthat")$is_testing()) {
getNamespace("testthat")$skip("shinytest2 is not installed")
} else {
stop("Please install 'shinytest2' package to use this class.")
}
}
My motivation is to avoid a lot of skip statements in the upstream packages like here.
There was a problem hiding this comment.
That's awesome, I'll create the PR in {teal} to do just this. I think the $is_testing() is not required as skip() throws an error and it's on testthat to capture it and handle
|
@averissimo is this still relevant? |
|
@m7pr it is, although it needs a new pass to make sure that nothing new has created a conflict here I'm moving it to draft |
* main: (42 commits) [skip actions] Bump version to 0.3.0.9061 Stop R process if AppDriver fails in `test-examples` (#820) [skip actions] Bump version to 0.3.0.9060 87 remove datasets - decrease package size (#818) [skip actions] Bump version to 0.3.0.9059 Fix documentation note about links on r-devel (#817) [skip actions] Bump version to 0.3.0.9058 get back staged deps config (#816) [skip actions] Bump version to 0.3.0.9057 add setup-r-dependencies (#815) [skip actions] Bump version to 0.3.0.9056 Teal version bump (#814) [skip actions] Bump version to 0.3.0.9055 🗃️ `decorators` feature branch (#795) [skip actions] Bump version to 0.3.0.9054 `teal.data::datanames()` is deprecated in favor of dot-prefix and `names()` (#794) [skip actions] Bump version to 0.3.0.9053 Adds `roxy.shinylive` to pre-commit configuration (#793) [skip actions] Bump version to 0.3.0.9052 add rmarkdown to VignetteBuilder (#792) ...
| @@ -31,16 +31,30 @@ Depends: | |||
| teal.transform (>= 0.5.0.9015) | |||
There was a problem hiding this comment.
Teal requirement needs to be bumped with insightsengineering/teal#1432
Possibly to teal (>= 0.15.2.9091),
Keeping conversation open until the PR is closed
There was a problem hiding this comment.
I see changes in dependencies and I immediately think about verdepcheck. Can you please confirm that it is passing on this? If not - let's work on the deps versions.
This might need to wait for https://github.com/insightsengineering/teal.modules.general/pull/774/files#r1890465398
Pull Request
Fixes #518
Note on removals:
broomas thebroom:glancesmethod can be replaced withgenerics::glancesChanges description
{broom}dependencyrlangconditionally