Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 771 fix failed pipelines #789

Merged
merged 12 commits into from
Oct 7, 2024
Merged

WIP 771 fix failed pipelines #789

merged 12 commits into from
Oct 7, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 3, 2024

@m7pr m7pr added the core label Oct 3, 2024
@m7pr m7pr requested a review from donyunardi October 3, 2024 13:22
Copy link
Contributor

github-actions bot commented Oct 3, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    827     827  0.00%    109-1069
R/tm_a_regression.R             773     773  0.00%    152-1030
R/tm_data_table.R               185     185  0.00%    102-341
R/tm_file_viewer.R              173     173  0.00%    48-256
R/tm_front_page.R               133     122  8.27%    74-232
R/tm_g_association.R            330     330  0.00%    136-538
R/tm_g_bivariate.R              672     410  38.99%   303-769, 810, 921, 938, 956, 967-989
R/tm_g_distribution.R          1048    1048  0.00%    127-1313
R/tm_g_response.R               351     351  0.00%    153-577
R/tm_g_scatterplot.R            722     722  0.00%    235-1058
R/tm_g_scatterplotmatrix.R      278     259  6.83%    174-481, 542, 556
R/tm_missing_data.R            1069    1069  0.00%    93-1318
R/tm_outliers.R                 985     985  0.00%    131-1260
R/tm_t_crosstable.R             251     251  0.00%    140-439
R/tm_variable_browser.R         830     825  0.60%    91-1083, 1121-1305
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8728    8428  3.44%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a701301

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Unit Tests Summary

  1 files   22 suites   13m 6s ⏱️
147 tests 147 ✅ 0 💤 0 ❌
479 runs  479 ✅ 0 💤 0 ❌

Results for commit a701301.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_pca 💔 $115.76$ $+1.29$ $0$ $0$ $0$ $0$
shinytest2-tm_file_viewer 💚 $36.06$ $-5.74$ $0$ $0$ $0$ $0$
shinytest2-tm_front_page 💚 $24.26$ $-2.78$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution 💔 $56.90$ $+1.16$ $0$ $0$ $0$ $0$
shinytest2-tm_g_response 💔 $27.88$ $+1.23$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💔 $72.82$ $+1.70$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💔 $99.56$ $+2.73$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_regression 💚 $10.38$ $-1.24$ e2e_tm_a_regression_Outlier_definition_and_label_are_visible_by_default.
shinytest2-tm_file_viewer 💚 $9.89$ $-1.93$ e2e_tm_file_viewer_Shows_selected_image_file
shinytest2-tm_file_viewer 💚 $10.03$ $-1.89$ e2e_tm_file_viewer_Shows_selected_text_file
shinytest2-tm_file_viewer 💚 $9.95$ $-1.87$ e2e_tm_file_viewer_Shows_selected_url
shinytest2-tm_front_page 💚 $10.17$ $-1.15$ e2e_tm_front_page_Verify_the_module_displays_metadata
shinytest2-tm_front_page 💚 $10.21$ $-1.74$ e2e_tm_front_page_Verify_the_module_displays_tables
shinytest2-tm_g_association 💚 $10.24$ $-1.75$ e2e_tm_g_association_Module_plot_is_visible.
shinytest2-tm_g_scatterplotmatrix 💚 $10.54$ $-1.66$ e2e_tm_g_scatterplotmatrix_Change_plot_settings
shinytest2-tm_misssing_data 💚 $13.29$ $-1.19$ e2e_tm_missing_data_Check_default_settings_and_visibility_of_the_combinations_graph_and_encodings
shinytest2-tm_variable_browser 💚 $13.69$ $-1.49$ e2e_tm_variable_browser_changing_outlier_definition_encoding_doesn_t_show_errors.

Results for commit 98a4745

♻️ This comment has been updated with latest results.

@m7pr m7pr changed the title 771 fix failed pipelines WIP 771 fix failed pipelines Oct 3, 2024
DESCRIPTION Outdated Show resolved Hide resolved
@m7pr
Copy link
Contributor Author

m7pr commented Oct 7, 2024

Hey @donyunardi, as agreed, I fixed r-hub checks and revdepcheck. This package is still failing in Scheduled job becuase of the failures of dependencies-test job (verdepcheck). I created a separate issue to handle that
#790

@donyunardi donyunardi merged commit d9fd08b into main Oct 7, 2024
49 checks passed
@donyunardi donyunardi deleted the fix-pipelines@main branch October 7, 2024 21:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failed pipeline
2 participants