-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce decorators for tm_missing_data
#809
Changes from 10 commits
cca4193
ad975fd
8f0687b
e5f7864
2c3c297
5a27da7
314e06c
524da4c
1368c2c
4243950
06f938e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After A LOT of debugging I solved the issue on this module and I was rethinking our decision on relying on the same decorators for all "outputs".
I'm proposing we allow 3 types of values in
decorators
argument (similar to the initial code from a week and half ago):list
ofteal_transform_module
(keep current list-like approach)list
that can allow for customizationslist(default = list(...))
is protected and applies to alllist(summary_plot = list(...))
only applies decorator forsummary_plot
list
ofteal_transform_module
We could limit to just
1.
and2.
, or even just2.
. WDYT?Why?
It seems odd to have all UIs on
tm_missing_data
, in particular, having plot-like decorators UI that do nothing on a table output.Note: the PR also extracts the
qenv
generation from the main shiny module into smaller and logic-only modules. I opted for using modules instead of just passinginput
to keep with good Shiny practices.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@averissimo yeah, so I think we could meet and rethink. I actually am having still various thoughs on how we should to it, depending on how the module is built. I think the named list of decorators would be the most appriopiate. I wonder how that changes the server logic.
Thanks for working on this module and having this fixed