198 Include user's card labels when generating the report #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: ee4fdb1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
…ineering/teal.osprey into 198_card_labels@main
m7pr
reviewed
Oct 12, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
m7pr
approved these changes
Oct 12, 2023
|
Hey @kartikeyakirar looks like this staged deps cyclic error does not appear on this PR anymore. You are good to merge |
kartikeyakirar
added a commit
to insightsengineering/teal
that referenced
this pull request
Oct 13, 2023
#933) this PR is extension to insightsengineering/teal.reporter#198 Here I have added card_template() function that generates a report card with a title, an optional description, and the option to append the filter state list. and is been used in insightsengineering/teal.modules.general#584 insightsengineering/teal.modules.clinical#835 insightsengineering/teal.modules.hermes#336 insightsengineering/teal.osprey#229 insightsengineering/teal.goshawk#241 ref issues and discussion: insightsengineering/teal.reporter#226 --------- Signed-off-by: kartikeya kirar <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Marcin <[email protected]> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #228
this is follow-up after insightsengineering/teal.reporter#219