Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

898 save app state version 3 #262

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

898 save app state version 3 #262

wants to merge 19 commits into from

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Mar 18, 2024

Companion to insightsengineering/teal#1011
Replaces uses of update*Input with server-side input creation with renderUI.

Copy link
Contributor

github-actions bot commented Mar 18, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             242     242  0.00%    83-361
R/tm_g_ae_sub.R               298     298  0.00%    59-395
R/tm_g_butterfly.R            381     381  0.00%    124-554
R/tm_g_decorate.R              46      46  0.00%    18-98
R/tm_g_events_term_id.R       286     286  0.00%    63-388
R/tm_g_heat_bygrade.R         320     320  0.00%    135-493
R/tm_g_patient_profile.R      708     708  0.00%    157-934
R/tm_g_spiderplot.R           326     326  0.00%    99-470
R/tm_g_swimlane.R             377     377  0.00%    124-559
R/tm_g_waterfall.R            429     429  0.00%    108-588
R/utils.R                      37      32  13.51%   32-91, 124-131
R/zzz.R                         2       2  0.00%    2-3
TOTAL                        3452    3447  0.14%

Diff against main

Filename                    Stmts    Miss  Cover
------------------------  -------  ------  --------
R/tm_g_ae_oview.R             -10     -10  +100.00%
R/tm_g_ae_sub.R               -17     -17  +100.00%
R/tm_g_butterfly.R             -7      -7  +100.00%
R/tm_g_events_term_id.R       -13     -13  +100.00%
R/tm_g_heat_bygrade.R          -2      -2  +100.00%
R/tm_g_patient_profile.R       -3      -3  +100.00%
R/tm_g_spiderplot.R            +2      +2  +100.00%
R/tm_g_swimlane.R              +1      +1  +100.00%
R/tm_g_waterfall.R             +2      +2  +100.00%
TOTAL                         -47     -47  +0.00%

Results for commit: db4b5f6

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 18, 2024

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit db4b5f6.

♻️ This comment has been updated with latest results.

@chlebowa
Copy link
Contributor Author

Finished verifying module bookmarkability.
The use of tm_g_decorate precludes bookmarking of Title and Footnote fields in tm_g_ae_overview, tm_g_events_term_id, and tm_g_ae_sub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant