Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GitHub Actions with setup-r-dependencies installation strategy - - - - Bye Bye staged-dependencies #1361

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 3, 2024

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Unit Tests Summary

  1 files   25 suites   8m 50s ⏱️
253 tests 249 ✅ 4 💤 0 ❌
508 runs  504 ✅ 4 💤 0 ❌

Results for commit 8d6e2e2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $65.69$ $-2.88$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💔 $37.64$ $+1.17$ $0$ $0$ $0$ $0$
shinytest2-modules 💔 $39.81$ $+1.42$ $0$ $0$ $0$ $0$
shinytest2-reporter 💔 $68.57$ $+2.93$ $0$ $0$ $0$ $0$
shinytest2-teal_slices 💔 $61.23$ $+1.13$ $0$ $0$ $0$ $0$
shinytest2-wunder_bar 💔 $22.40$ $+1.03$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-reporter 💔 $18.79$ $+1.35$ e2e_reporter_does_not_show_the_secondary_column_that_shows_filter_panel

Results for commit a80ed24

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  47      11  76.60%   27, 29, 41, 52-59
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                            108      50  53.70%   107-114, 160-169, 171, 183-204, 229-232, 239-245, 248-249, 251
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             189      68  64.02%   24-52, 93, 187, 227-267
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 68       0  100.00%
R/module_nested_tabs.R              220      93  57.73%   40-144, 176, 201-203, 317, 356
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 304-318, 321-332, 335-341, 355
R/module_teal_data.R                152      11  92.76%   41-48, 84, 135-136, 174
R/module_teal_lockfile.R            131      44  66.41%   32-36, 44-56, 59-61, 75, 85-87, 99-101, 109-118, 121, 123, 125-126, 160-161
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     190      87  54.21%   48-143, 158, 184-185, 216
R/module_transform_data.R            56      32  42.86%   17-51
R/modules.R                         181      32  82.32%   166-170, 225-228, 326-327, 359-373, 411, 423-431
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 43       0  100.00%
R/teal_data_utils.R                  32       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           203       0  100.00%
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3089    1261  59.18%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 8d6e2e2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr changed the title WIP Test for building pkgdown with setup-r-dependencies instead of staged-dependencies strategy Run GitHub Actions with setup-r-dependencies R dependencies installation strategy, instead of staged-dependencies strategy Oct 3, 2024
@m7pr m7pr changed the title Run GitHub Actions with setup-r-dependencies R dependencies installation strategy, instead of staged-dependencies strategy Run GitHub Actions with setup-r-dependencies installation strategy - Bye Bye staged-dependencies Oct 3, 2024
@m7pr m7pr changed the title Run GitHub Actions with setup-r-dependencies installation strategy - Bye Bye staged-dependencies Run GitHub Actions with setup-r-dependencies installation strategy - - - - Bye Bye staged-dependencies Oct 3, 2024
@m7pr m7pr requested a review from pawelru October 3, 2024 11:10
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!
Thanks!

@m7pr m7pr merged commit cae7d4e into main Oct 3, 2024
26 checks passed
@m7pr m7pr deleted the setup-r-dependencies-test@main branch October 3, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@cicdguy
Copy link
Contributor

cicdguy commented Oct 14, 2024

This is AWESOME 🔥

@m7pr
Copy link
Contributor Author

m7pr commented Oct 14, 2024

We will extend to other packages as well :) insightsengineering/nestdevs-tasks#65

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants