Fix disable-timeline on desktop #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
"Disable timeline" wasn't working properly on the desktop. Redirecting to twitter.com lands on "/home" instead of redirecting to
disableTimelineRedirect.Cause
It was caused by unable to locate the "disableTimelineRedirect" most likely due to a rendering timing issue.
error I found when I was debugging locally
Solution
Add setTimeout, I also try to make the redirect straightforward: instead of locating the link, why can't we just redirect to the path? Let me know if this impacts other observer behaviours.