add classifier keywords remove script #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michamos
reviewed
Sep 16, 2024
Comment on lines
20
to
22
| for keyword in record.get("keywords", []): | ||
| if keyword.get("source", "") == "classifier": | ||
| record["keywords"].remove(keyword) |
There was a problem hiding this comment.
are you sure mutating a list you're iterating on works correctly? the safer approach is usually to build a new list that only contains the elements you need, like in
curation-scripts/scripts/remove-bai-from-lit-authors/script.py
Lines 28 to 34 in c4d4f74
There was a problem hiding this comment.
You are right, it would not work correctly like this. I changed it now :)
PascalEgn
force-pushed
the
add-classifier-keywords-remove-script
branch
from
a78e9d3 to
ff119c5
Compare
PascalEgn
force-pushed
the
add-classifier-keywords-remove-script
branch
from
6223e64 to
ba18a6b
Compare
michamos
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: cern-sis/issues-inspire#554