Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspire-utils bump and check packages #101

Merged
merged 1 commit into from
Dec 3, 2024
Merged

inspire-utils bump and check packages #101

merged 1 commit into from
Dec 3, 2024

Conversation

DonHaul
Copy link
Contributor

@DonHaul DonHaul commented Dec 2, 2024

No description provided.

@DonHaul DonHaul linked an issue Dec 2, 2024 that may be closed by this pull request
bump inspire-utils cern-sis/issues-inspire#625
Closed
@DonHaul
Copy link
Contributor Author

DonHaul commented Dec 2, 2024 •
edited
Loading

urllib is not even being used. removed it
Took the opportunity to add dockerfiles to make sure it works locally

@DonHaul DonHaul changed the title Urllib3 up inspire-utils bump and check packages Dec 2, 2024
@DonHaul DonHaul force-pushed the urllib3-up branch 3 times, most recently from 0d94671 to 790bbf5 Compare December 3, 2024 09:30
drjova
drjova reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@drjova drjova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small update

README.md Outdated
docker run -it inspire-utils:py2 /bin/bash

# inside the container
pytest tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker run inspire-utils:py2 pytest tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@DonHaul DonHaul force-pushed the urllib3-up branch 2 times, most recently from 5a5dc0b to af14dc4 Compare December 3, 2024 13:38
@DonHaul
Copy link
Contributor Author

DonHaul commented Dec 3, 2024

Found python:2.7.18-buster that already includes all the dependencies needed for lxml - updated docker image

drjova
drjova reviewed Dec 3, 2024
View reviewed changes
Dockerfile Outdated

COPY . .

# RUN python2.7 -m pip install -e .[tests]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this file right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, removed

@DonHaul DonHaul merged commit 0c591a8 into master Dec 3, 2024
5 checks passed
@drjova drjova deleted the urllib3-up branch December 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drjova drjova drjova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump inspire-utils
2 participants
@DonHaul @drjova