Redact the full url in AsyncCall thread name.

We don't want to accidentally leak sensitive information that may be embedded in the url.
inspireso · Apr 21, 2016 · 047b568 · 047b568
1 parent b26ad3e
commit 047b568
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/okhttp/src/main/java/okhttp3/RealCall.java b/okhttp/src/main/java/okhttp3/RealCall.java
@@ -96,7 +96,7 @@ final class AsyncCall extends NamedRunnable {
     private final boolean forWebSocket;
 
     private AsyncCall(Callback responseCallback, boolean forWebSocket) {
-      super("OkHttp %s", originalRequest.url().toString());
+      super("OkHttp %s", redactedUrl().toString());
       this.responseCallback = responseCallback;
       this.forWebSocket = forWebSocket;
     }
@@ -151,8 +151,11 @@ RealCall get() {
    */
   private String toLoggableString() {
     String string = canceled ? "canceled call" : "call";
-    HttpUrl redactedUrl = originalRequest.url().resolve("/...");
-    return string + " to " + redactedUrl;
+    return string + " to " + redactedUrl();
+  }
+
+  HttpUrl redactedUrl() {
+    return originalRequest.url().resolve("/...");
   }
 
   private Response getResponseWithInterceptorChain(boolean forWebSocket) throws IOException {