Zookeeper CR codebase refactor #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
force-pushed
the
zookeeper-codebase-ref
branch
from
1782400
to
c3c8d66
Compare
ribaraka
requested changes
Feb 28, 2024
apis/clusters/v1beta1/structs.go
Outdated
Comment on lines
61
to
62
| CDCID string `json:"cdcid,omitempty"` | ||
| TwoFactorDeleteEnabled bool `json:"twoFactorDeleteEnabled,omitempty"` |
There was a problem hiding this comment.
please correct me if I'm wrong, but I believe these two fields should be removed
There was a problem hiding this comment.
I believe even entire struct is not being used.
There was a problem hiding this comment.
Removed it as unused
worryg0d
force-pushed
the
zookeeper-codebase-ref
branch
from
c3c8d66
to
e202f7a
Compare
ribaraka
approved these changes
Feb 28, 2024
testisnullus
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides: