Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): remove most dependencies from controller #405

Merged

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Aug 17, 2023

Because

  • reduce dependency cycle between controller-model and model-backend

This commit

  • remove resource updating from model-backend to controller-model to avoid api calls cycle
  • update public deploy/undeploy methods to change the desire state only, and let controller-model handle the actual deployment request
  • update integration-test regarding to the deploy/undeploy public methods

@linear
Copy link

linear bot commented Aug 17, 2023

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (6a01138) 1.56% compared to head (2481315) 1.59%.

❗ Current head 2481315 differs from pull request most recent head 67b87fd. Consider uploading reports for the commit 67b87fd to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #405      +/-   ##
========================================
+ Coverage   1.56%   1.59%   +0.02%     
========================================
  Files         11      11              
  Lines       5160    5070      -90     
========================================
  Hits          81      81              
+ Misses      5058    4968      -90     
  Partials      21      21              
Flag Coverage Δ
unittests 1.59% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/handler/private_handler.go 0.00% <0.00%> (ø)
pkg/handler/public_handler.go 0.00% <0.00%> (ø)
pkg/service/service.go 11.72% <0.00%> (+0.25%) ⬆️
pkg/service/worker.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit 69d9790 into main Aug 18, 2023
8 checks passed
@heiruwu heiruwu deleted the heiru/ins-1570-refactor-publicprivate-model-deployundeploy branch August 18, 2023 11:50
heiruwu added a commit that referenced this pull request Aug 18, 2023
Because

- reduce dependency cycle between `controller-model` and `model-backend`

This commit

- remove resource updating from `model-backend` to `controller-model` to
avoid api calls cycle
- update public deploy/undeploy methods to change the desire state only,
and let `controller-model` handle the actual deployment request
- update integration-test regarding to the deploy/undeploy public
methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant