Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): not return minio error in list model run #696

Merged

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 16, 2024

Because

  • list model run should return results even if there is an error in minio

This commit

  • log errors instead of return error

Copy link

linear bot commented Oct 16, 2024

heiruwu
heiruwu previously approved these changes Oct 16, 2024
@joremysh joremysh force-pushed the jeremy/ins-6535-cant-view-the-run-logging-on-the-last-page branch 2 times, most recently from 446fddd to 427e585 Compare October 16, 2024 07:58
@joremysh joremysh merged commit cbeea05 into main Oct 16, 2024
11 checks passed
@joremysh joremysh deleted the jeremy/ins-6535-cant-view-the-run-logging-on-the-last-page branch October 16, 2024 08:22
heiruwu pushed a commit that referenced this pull request Oct 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.31.0-alpha](v0.30.2-alpha...v0.31.0-alpha)
(2024-10-22)


### Features

* **run:** run logging data list by requester API
([#695](#695))
([b118026](b118026))
* **service:** standardize the tag naming convention
([#700](#700))
([e08be0d](e08be0d))


### Bug Fixes

* **ray:** fix upscale deployment failure
([#698](#698))
([96563c9](96563c9))
* **run:** fix run logging update function
([#699](#699))
([a753fe4](a753fe4))
* **run:** not return minio error in list model run
([#696](#696))
([cbeea05](cbeea05))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants