Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): standardize the tag naming convention #700

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(service): standardize the tag naming convention #700

merged 1 commit into from
Oct 22, 2024

Conversation

donch1989
Copy link
Member

Because

  • We didn't apply any naming convention on tags

This commit

  • Standardizes the tag naming convention to match the following criteria:
    • All user-defined tags will be converted to lowercase.
    • All system/reserved tags will be capitalized.

@linear Linear
Copy link

linear bot commented Oct 22, 2024

INS-6621 [Backend] Rules for Capitalization of System and Non-System Tags

@donch1989 donch1989 marked this pull request as draft October 22, 2024 05:16
@donch1989 donch1989 marked this pull request as ready for review October 22, 2024 05:16
@donch1989 donch1989 changed the title feat: standardize the tag naming convention feat(service): standardize the tag naming convention Oct 22, 2024
@donch1989 donch1989 merged commit e08be0d into main Oct 22, 2024
12 of 13 checks passed
@donch1989 donch1989 deleted the huitang/ins-6621 branch October 22, 2024 05:36
@droplet-bot droplet-bot mentioned this pull request Oct 16, 2024
Merged
heiruwu pushed a commit that referenced this pull request Oct 22, 2024
@droplet-bot
chore(main): release 0.31.0-alpha (#697)
e4d733d 
🤖 I have created a release *beep* *boop*
---


##
[0.31.0-alpha](v0.30.2-alpha...v0.31.0-alpha)
(2024-10-22)


### Features

* **run:** run logging data list by requester API
([#695](#695))
([b118026](b118026))
* **service:** standardize the tag naming convention
([#700](#700))
([e08be0d](e08be0d))


### Bug Fixes

* **ray:** fix upscale deployment failure
([#698](#698))
([96563c9](96563c9))
* **run:** fix run logging update function
([#699](#699))
([a753fe4](a753fe4))
* **run:** not return minio error in list model run
([#696](#696))
([cbeea05](cbeea05))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu heiruwu approved these changes

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
instill model
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donch1989 @heiruwu @droplet-bot