-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segmenting search queries example #127
Add segmenting search queries example #127
Conversation
|
.object({ | ||
title: z.string().describe("Title of the request"), | ||
query: z.string().describe("Query to search fro relevant content"), | ||
type: SearchTypeSchema.describe("Type of search") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is being defined independently with its own description, and you are adding a description here - I wonder what the actual JSON schema output is - tbh I'm not sure - does this double up the description on this one property? does the second supersede the first? You probably don't need 2, though, to describe this same property, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would just replace it with type: z.enum.
No description provided.