Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segmenting search queries example #127

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

wintersausten
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: c239b9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

.object({
title: z.string().describe("Title of the request"),
query: z.string().describe("Query to search fro relevant content"),
type: SearchTypeSchema.describe("Type of search")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is being defined independently with its own description, and you are adding a description here - I wonder what the actual JSON schema output is - tbh I'm not sure - does this double up the description on this one property? does the second supersede the first? You probably don't need 2, though, to describe this same property, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would just replace it with type: z.enum.

@roodboi roodboi merged commit 3fb0b08 into instructor-ai:main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants