Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow request option pass through #164

Merged
merged 7 commits into from
Apr 20, 2024
Merged

allow request option pass through #164

merged 7 commits into from
Apr 20, 2024

Conversation

roodboi
Copy link
Collaborator

@roodboi roodboi commented Apr 20, 2024

We never passed the second arg through - added with type + basic test + updated error handling slightly to make sure we pass it all the way through

Copy link

changeset-bot bot commented Apr 20, 2024

🦋 Changeset detected

Latest commit: eed43c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@instructor-ai/instructor Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Apr 20, 2024

Deploying instructor-js with  Cloudflare Pages  Cloudflare Pages

Latest commit: eed43c3
Status: ✅  Deploy successful!
Preview URL: https://5f617432.instructor-js.pages.dev
Branch Preview URL: https://request-options-and-errors.instructor-js.pages.dev

View logs

@roodboi roodboi marked this pull request as ready for review April 20, 2024 13:33
@roodboi roodboi linked an issue Apr 20, 2024 that may be closed by this pull request
@roodboi roodboi requested a review from jxnl April 20, 2024 16:54
@roodboi roodboi merged commit 6942d65 into main Apr 20, 2024
3 checks passed
@roodboi roodboi deleted the request-options-and-errors branch April 20, 2024 17:00
@roodboi roodboi mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use request options with response model enabled
1 participant