Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating deps and tests #191

Merged
merged 4 commits into from
Oct 19, 2024
Merged

updating deps and tests #191

merged 4 commits into from
Oct 19, 2024

Conversation

roodboi
Copy link
Collaborator

@roodboi roodboi commented Oct 19, 2024

  • remove model validation so we dont fall behind and throw un-necessary warnings
  • remove any scale tests for now since they removed public endpoints this summer (need access to platform to re-enable)
  • update deps to support the latest and avoid mismatch issues with zod coming from the latest oai

CleanShot 2024-10-19 at 10 57 53@2x


Important

Update dependencies, remove model validation, and adjust tests due to changes in public endpoints.

  • Dependencies:
    • Update zod-stream to 2.0.0 and zod-validation-error to ^3.4.0 in package.json.
    • Update openai to >=4.58.0 in peerDependencies and 4.68.1 in devDependencies.
    • Update @anthropic-ai/sdk to 0.29.2 and llm-polyglot to 2.2.0.
  • Model Validation:
    • Remove validateModelModeSupport() from Instructor class in instructor.ts.
    • Remove PROVIDER_SUPPORTED_MODES_BY_MODEL usage in instructor.ts and mode.test.ts.
  • Tests:
    • Remove scale tests in mode.test.ts due to removal of public endpoints.
    • Update default model in mode.test.ts to meta-llama/Llama-3.2-90B-Vision-Instruct-Turbo.
    • Minor content change in zod-type.test.ts for test message.

This description was created by Ellipsis for 000a1c8. It will automatically update as commits are pushed.

…rt latest and avoid mismatch issues with zod coming from latest oai
Copy link

changeset-bot bot commented Oct 19, 2024

🦋 Changeset detected

Latest commit: 5f3d553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@instructor-ai/instructor Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Oct 19, 2024

Deploying instructor-js with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f3d553
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4f786a8 in 12 seconds

More details
  • Looked at 197 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. src/instructor.ts:88
  • Draft comment:
    Removing validateModelModeSupport might lead to runtime errors if unsupported models are used with certain providers. Ensure this change won't cause issues elsewhere.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of the validateModelModeSupport function in instructor.ts is consistent with the PR description, which mentions removing model validation. However, this function was responsible for ensuring that a model is supported by a provider in a specific mode. Without this validation, there might be a risk of using unsupported models with certain providers, which could lead to runtime errors. It's important to ensure that this change won't cause issues elsewhere in the codebase.
2. tests/mode.test.ts:7
  • Draft comment:
    The PROVIDER_SUPPORTED_MODES_BY_MODEL is no longer used in the main code. Ensure tests are updated to reflect the removal of model validation logic.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_vQJGlDbVrGxDunoD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on a43c88d in 10 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .changeset/silly-bikes-float.md:7
  • Draft comment:
    Add a newline at the end of the file for consistency and to follow best practices.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The changeset file is missing a newline at the end, which is a common best practice for text files.
2. .changeset/silly-bikes-float.md:1
  • Draft comment:
    Ensure this new markdown file is added to mkdocs.yml for documentation purposes.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_vJNMJjgTNmfSLSi0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 000a1c8 in 15 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .changeset/silly-bikes-float.md:2
  • Draft comment:
    The changeset indicates a minor version update, but the description suggests a major update due to peer dependencies. Ensure the versioning aligns with the changes made.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. .changeset/silly-bikes-float.md:1
  • Draft comment:
    Ensure this new markdown file is added to mkdocs.yml for documentation purposes.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_PjTmApdGuML9Isil


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@roodboi roodboi merged commit bf240b2 into main Oct 19, 2024
1 of 3 checks passed
@roodboi roodboi deleted the update-tests-and-deps branch October 19, 2024 15:13
@roodboi roodboi restored the update-tests-and-deps branch October 19, 2024 15:16
@roodboi roodboi mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant