-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating deps and tests #191
Conversation
…rt latest and avoid mismatch issues with zod coming from latest oai
🦋 Changeset detectedLatest commit: 5f3d553 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 4f786a8 in 12 seconds
More details
- Looked at
197
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. src/instructor.ts:88
- Draft comment:
RemovingvalidateModelModeSupport
might lead to runtime errors if unsupported models are used with certain providers. Ensure this change won't cause issues elsewhere. - Reason this comment was not posted:
Confidence changes required:50%
The removal of thevalidateModelModeSupport
function ininstructor.ts
is consistent with the PR description, which mentions removing model validation. However, this function was responsible for ensuring that a model is supported by a provider in a specific mode. Without this validation, there might be a risk of using unsupported models with certain providers, which could lead to runtime errors. It's important to ensure that this change won't cause issues elsewhere in the codebase.
2. tests/mode.test.ts:7
- Draft comment:
ThePROVIDER_SUPPORTED_MODES_BY_MODEL
is no longer used in the main code. Ensure tests are updated to reflect the removal of model validation logic. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_vQJGlDbVrGxDunoD
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on a43c88d in 10 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .changeset/silly-bikes-float.md:7
- Draft comment:
Add a newline at the end of the file for consistency and to follow best practices. - Reason this comment was not posted:
Confidence changes required:33%
The changeset file is missing a newline at the end, which is a common best practice for text files.
2. .changeset/silly-bikes-float.md:1
- Draft comment:
Ensure this new markdown file is added to mkdocs.yml for documentation purposes. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_vJNMJjgTNmfSLSi0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 000a1c8 in 15 seconds
More details
- Looked at
14
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .changeset/silly-bikes-float.md:2
- Draft comment:
The changeset indicates a minor version update, but the description suggests a major update due to peer dependencies. Ensure the versioning aligns with the changes made. - Reason this comment was not posted:
Comment did not seem useful.
2. .changeset/silly-bikes-float.md:1
- Draft comment:
Ensure this new markdown file is added to mkdocs.yml for documentation purposes. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_PjTmApdGuML9Isil
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Update dependencies, remove model validation, and adjust tests due to changes in public endpoints.
zod-stream
to2.0.0
andzod-validation-error
to^3.4.0
inpackage.json
.openai
to>=4.58.0
inpeerDependencies
and4.68.1
indevDependencies
.@anthropic-ai/sdk
to0.29.2
andllm-polyglot
to2.2.0
.validateModelModeSupport()
fromInstructor
class ininstructor.ts
.PROVIDER_SUPPORTED_MODES_BY_MODEL
usage ininstructor.ts
andmode.test.ts
.mode.test.ts
due to removal of public endpoints.mode.test.ts
tometa-llama/Llama-3.2-90B-Vision-Instruct-Turbo
.zod-type.test.ts
for test message.This description was created by for 000a1c8. It will automatically update as commits are pushed.