- Display error message if imsmanifest.xml can't be found #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mojocakes
commented
Jun 13, 2021
| @@ -205,7 +205,7 @@ export default class CommonCartridge extends Component { | |||
| entry => entry.filename === "imsmanifest.xml" | |||
| ); | |||
|
|
|||
| if (manifestEntry != null) { | |||
| if (manifestEntry) { | |||
There was a problem hiding this comment.
value is undefined if not found
|
Bump? ;) |
|
@mojocakes Hi, can you provide an example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I was getting a blank white screen whenever I dropped my .imscc file onto the page.
After some debugging I realised that I was building my export file incorrectly; file paths were being prepended with a
/(so/imsmanifest.xmlinstead ofimsmanifest.xml)This was clearly an error on my side, but I think the app should still display an error message to tell the user that their file is not a valid Common Cartridge.
Changes
Display error message if the
imsmanifest.xmlfile can't be extracted.